Changes between Initial Version and Version 1 of Ticket #29051, comment 4


Ignore:
Timestamp:
Mar 15, 2018, 6:59:07 PM (6 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #29051, comment 4

    initial v1  
    66The patchfile added in r64476 has this comment: {{{/* Carbon is not available on 64-bit */}}}, but nothing is done to test for 64-bit, and {{{HAVE_CARBON}}} is undefined anyway (originally this was decided by the maintainer for the packaged versions of GIMP on OS X, to have GIMP behave consistently on all supported platforms [*]).
    77
    8 Could the patch file include a test for 64bit, like e.g. in this [http://trac.macports.org/browser/trunk/dports/graphics/gimp2/files/patch-plug-ins-twain-tw_mac.c.diff?rev=61996 GIMP patch file], only reversed (i.e. if {{{__LP64__}}} is defined, undefine {{{HAVE_CARBON}}})?
     8Could the patch file include a test for 64bit, like e.g. in this [browser:trunk/dports/graphics/gimp2/files/patch-plug-ins-twain-tw_mac.c.diff@61996 GIMP patch file], only reversed (i.e. if {{{__LP64__}}} is defined, undefine {{{HAVE_CARBON}}})?
    99
    1010