Opened 12 years ago
Last modified 4 years ago
#34231 closed defect
ImageMagick: should not depend on pango + fix openMP — at Version 1
| Reported by: | devernay (Frédéric Devernay) | Owned by: | ryandesign@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.0.4 |
| Keywords: | haspatch | Cc: | |
| Port: | ImageMagick |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
this patch fixes two things:
- if pango is installed, configure detects it and thus it becomes a "hidden dependency". TYhis patch makes the dependency exlicit with the +pango variant
- OpenMP is broken in gcc 4.0 and 4.2, so disable it on these compilers.
Change History (2)
Changed 12 years ago by devernay (Frédéric Devernay)
| Attachment: | ImageMagick-Portfile.patch added |
|---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Description: | modified (diff) |
|---|---|
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to ryandesign@… |
Replying to frederic.devernay@…:
- if pango is installed, configure detects it and thus it becomes a "hidden dependency". TYhis patch makes the dependency exlicit with the +pango variant
Thanks; I had overlooked that. Committed that part in r92396 along with a minor version update (since a revision increase would have been needed otherwise, and we might as well instead pull in some upstream bug fixes while we're at it). Note that I rewrote the pango dependency so that pango-devel could satisfy it.
This also means we have to close #20923 as wontfix, which I'm quite happy to do.
- OpenMP is broken in gcc 4.0 and 4.2, so disable it on these compilers.
That's news to me. You should probably report that to the developers of ImageMagick so that they can fix their use of OpenMP on gcc 4.2. My understanding is that ImageMagick did not attempt to use OpenMP automatically on gcc earlier than 4.2, but that it could still be added. See also #15945 and #24944 and #32642.
Portfile patch