Opened 12 years ago

Closed 8 years ago

#35616 closed enhancement (wontfix)

gnuplot: options for setting default terminal

Reported by: mojca (Mojca Miklavec) Owned by: mojca (Mojca Miklavec)
Priority: Low Milestone:
Component: ports Version:
Keywords: Cc: ruedas@…, ryandesign (Ryan Carsten Schmidt)
Port: gnuplot

Description

I would like to provoke some discussion about what you think of adding the following variants to gnuplot:

  • default_aquaterm
  • default_qt
  • default_wxt
  • default_x11

Another 'quick & dirty' patch for setting the default terminal is just disabling aquaterm with -aquaterm (and a tiny bit of extra code), see also #34423.

I can add the patch at any time, as soon as I get some feedback. So far I got one vote of support for default_<term> from Thomas in #33596 and one against from Ryan on the mailing list.

I'm open to better suggestions to set the default terminal.

Change History (4)

comment:1 Changed 12 years ago by mf2k (Frank Schima)

Cc: ryandesign@… added; mojca.miklavec.lists@… ryandesign removed
Version: 2.1.2

You don't need to Cc yourself. Also, trac requires complete email addresses.

As someone who doesn't use gnuplot, I don't understand what the "default" variants you are proposing are supposed to do. Also, you are the maintainer so if you want it, then add the patch so we can look at it.

comment:2 Changed 11 years ago by mojca (Mojca Miklavec)

Owner: changed from macports-tickets@… to mojca@…

comment:3 Changed 11 years ago by mojca (Mojca Miklavec)

This is what I had in mind:

variant default_aquaterm depends aquaterm conflicts default_qt default_wxt default_x11 description "Use 'aquaterm' as default terminal" {
    configure.cflags-append -DDEFAULTTERM='"aqua"'
}
variant default_qt depends qt conflicts default_aquaterm default_wxt default_x11 description "Use 'qt' as default terminal" {
    configure.cflags-append -DDEFAULTTERM='"qt"'
}
variant default_wxt depends wxwidgets conflicts default_aquaterm default_qt default_x11 description "Use 'wxt' as default terminal" {
    configure.cflags-append -DDEFAULTTERM='"wxt"'
}
variant default_x11 depends x11 conflicts default_aquaterm default_qt default_wxt description "Use 'x11' as default terminal" {
    configure.cflags-append -DDEFAULTTERM='"x11"'
}

Possibly (but not necessarily) followed by

if{![variant_isset default_aquaterm] && ![variant_isset default_qt] && ![variant_isset default_wxt] && ![variant_isset default_x11]} {
    if{[variant_isset qt]} {
        default_variants-append +default_qt
    } else {
        ...
    }
}
Version 0, edited 11 years ago by mojca (Mojca Miklavec) (next)

comment:4 Changed 8 years ago by mojca (Mojca Miklavec)

Resolution: wontfix
Status: newclosed

Closing this for lack of interest (and too many variants, making the port overly confusing). There is still time to convince me otherwise.

Note: See TracTickets for help on using tickets.