Changes between Initial Version and Version 2 of Ticket #35949


Ignore:
Timestamp:
Sep 5, 2012, 2:01:15 PM (12 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

povray 3.6.1 was released in 2004; it's not surprising it's not compatible with libpng 1.5.

For other software affected by this incompatibility I've been able to find patches in other distributions to fix it. But for povray what I found is that they instead updated to a release candidate of 3.7.0, and I'm inclined to agree that's a better choice, since 3.6.1 is so old. I'm attaching a patch that updates the port to 3.7.0.RC6, and a few extra patches needed to make this compile. It builds for me on Mountain Lion, but I am not familiar with povray and don't know how to test whether it functions correctly. If there are no objections, I'll commit it, but I would prefer to first have confirmation that it works (from someone familiar with povray).

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #35949

    • Property Cc ryandesign@… added
    • Property Keywords haspatch added; libpng removed
    • Property Summary changed from povray @3.6.1_7 Build failure to povray @3.6.1_7 Build failure with libpng 1.5

  • Ticket #35949 – Description

    initial v2  
    1515   /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_povray/povray/main.log
    1616Error: Unable to upgrade port: 1
    17 }}}}
     17}}}
    1818
    1919
    2020In the log, aside from many "deprecated" warnings, the first error listed is:
    2121
    22 {{{{:info:build png_pov.cpp:170:19: error: member access into incomplete type 'png_struct' (aka 'png_struct_def')
     22{{{
     23:info:build png_pov.cpp:170:19: error: member access into incomplete type 'png_struct' (aka 'png_struct_def')
    2324:info:build           longjmp(png_ptr->jmpbuf,1);
    24 :info:build     }}}}                     ^
    25 
     25:info:build                          ^
     26}}}
    2627
    2728There were numerous other errors of the same kind.
    2829
    29 In response to a message I posted to macports-users@lists.macosforge.org, Jeremy Lavergne <jeremy@lavergne.gotdns.org> replied, "That's due to the libpng API change recently; we'll need to update all the packages affected."
     30In response to a message I posted to macports-users@lists.macosforge.org, Jeremy Lavergne replied, "That's due to the libpng API change recently; we'll need to update all the packages affected."