Opened 11 years ago

Last modified 10 years ago

#37352 closed update

torsocks: Fixes for #36806 and #36807 — at Version 1

Reported by: sami.laine@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: ryandesign@…
Port: torsocks

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Updated Portfile for torsocks package, includes fixes for #36806 and #36807.

Change History (1)

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Description: modified (diff)
Keywords: haspatch added
Summary: Fixes for #38606 and #36807torsocks: Fixes for #36806 and #36807

Thank you but this patch has a few problems:

  • it mixes whitespace and functional changes
  • it introduces your name into the maintainers line, which should only contain (obfuscated) email addresses
  • it changes "OS X" (which is the correct name of the OS) to "Mac OSX"
  • it adds a "dist_subdir" line which is unnecessary unless a stealth update has occurred, which I assume it hasn't since you haven't changed the checksums
  • it removes the license line
  • it adds "--prefix=${prefix}" to configure.args which is unnecessary because MacPorts automatically puts that into configure.pre_args
  • it changes master_sites from the simple and recommended googlecode to a more verbose URL
  • it adds an unnecessary "# end of file." comment
Note: See TracTickets for help on using tickets.