Opened 11 years ago

Last modified 4 years ago

#39756 closed defect

Adding runtime dep of yelp to gnome apps breaks +quartz variant — at Version 1

Reported by: c.herbig@… Owned by: devans@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: yelp

Description (last modified by larryv (Lawrence Velázquez))

Yelp does not compile for +quartz due to some X11 specific calls in the yelp-application.c file. Forcing it as a dependency, even though these programs technically do not depend on it (unless you want to browse the help), breaks the ability to even run them at all.

Specifically it is the function application_uri_resolved, if this could be fixed:

...
...
...
yelp_window_load_uri (window, uri);

    gtk_widget_show_all (GTK_WIDGET (window));

    /* Metacity no longer does anything useful with gtk_window_present */
    gdk_window = gtk_widget_get_window (GTK_WIDGET (window));
    if (gdk_window)
        gdk_x11_window_move_to_current_desktop (gdk_window);

    /* Ensure we actually present the window when invoked from the command
     * line. This is somewhat evil, but the minor evil of Yelp stealing
     * focus (after you requested it) is outweighed for me by the major
     * evil of no help window appearing when you click Help.
     */
    if (data->timestamp == 0)
        data->timestamp = gdk_x11_get_server_time (gtk_widget_get_window (GTK_WIDGET (window)));

    gtk_window_present_with_time (GTK_WINDOW (window), data->timestamp);

    g_free (data);
}

then everything should be fine. I would imagine that since a +quartz environment doesn't need metacity, it could perhaps be patched out...

This issue was described here #39571

Change History (1)

comment:1 Changed 11 years ago by larryv (Lawrence Velázquez)

Cc: devans@… removed
Description: modified (diff)
Owner: changed from macports-tickets@… to devans@…
Note: See TracTickets for help on using tickets.