Changes between Initial Version and Version 1 of Ticket #40803, comment 9


Ignore:
Timestamp:
Jun 14, 2014, 1:34:25 PM (10 years ago)
Author:
mojca (Mojca Miklavec)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #40803, comment 9

    initial v1  
    4848}}}
    4949
    50 I didn't specifically test version 3.1.0 yet (I plan to keep using this one for a while), but it would be very nice to get more feedback about what exactly is failing in 3.1.0, so that we can report any remaining problems and switch to 3.1.0 once it gets released.
     50I didn't specifically test version 3.1.0 yet (I plan to keep using 3.1.1pre2 now), but it would be very nice to get more feedback about what exactly is failing in 3.1.0, so that we can test and report any remaining problems and switch to 3.1.1 once it gets released. I wouldn't be surprised if 3.1.0 failed for the maintainer because rsync included headers from external zlib and then linked to the internal one (or any other weird combination like that).
    5151
    5252I had to remove
    … …  
    6565
    6666Rsync seems to prefer the modified build-in zlib library. Adding `-I/opt/local/include` prevents rsync from finding the files from the built-in zlib library because then `-I/opt/local/include` comes in front of `-I./zlib`. I reported the problem upstream, asking them to put "-I./zlib" in front of `CFLAGS`. But I don't understand the need for changing `CFLAGS` in the rsync port anyway.
     67
     68I get two warnings:
     69{{{
     70uidlist.c:533:44: warning: passing 'gid_t *' (aka 'unsigned int *') to parameter of type 'int *' converts between pointers to integer types with different sign [-Wpointer-sign]
     71        if (getgrouplist(pw->pw_name, pw->pw_gid, gid_list, size_ptr) < 0)
     72                                                  ^~~~~~~~
     73/usr/include/unistd.h:698:43: note: passing argument to parameter here
     74int      getgrouplist(const char *, int, int *, int *);
     75                                              ^
     761 warning generated.
     77
     78
     79acls.c:742:84: warning: unused parameter 'mode' [-Wunused-parameter]
     80static int recv_rsync_acl(int f, item_list *racl_list, SMB_ACL_TYPE_T type, mode_t mode)
     81                                                                                   ^
     821 warning generated.
     83}}}