Opened 10 years ago
Closed 10 years ago
#42278 closed update (fixed)
mozjs17: update to latest version 24.2, perhaps rename to mozjs
| Reported by: | dbevans (David B. Evans) | Owned by: | juanrgar (Juan R. García Blanco) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | Cc: | cooljeanius (Eric Gallager) | |
| Port: | mozjs17 |
Description
Latest unstable version of gjs 1.39.3 now requires mozjs-24 to build. You might want to rename the port this once to just mozjs to avoid having to rename the port for future version updates like this.
Attachments (1)
Change History (11)
comment:1 Changed 10 years ago by dbevans (David B. Evans)
| Type: | defect → update |
|---|
comment:2 Changed 10 years ago by cooljeanius (Eric Gallager)
| Cc: | egall@… added |
|---|
comment:3 follow-up: 6 Changed 10 years ago by juanrgar (Juan R. García Blanco)
Oops, I didn't get an email notification of this ticket because I wrote ...@… instead of ...@… in the maintainers entry of mozjs17. I'll cc me now.
I would keep the version attached to the package name in this case. mozjs17 installs a pc file that has the version attached (i.e. mozjs-17.0), and therefore gjs 1.38.0 checks for that specific module. Renaming mozjs17 to mozjs and updating it from v17 to v24 would result in gjs not building. So I think the approach we should take is to have different ports for mozjs17 and mozjs24.
I'm working on a mozjs24 Portfile. As soon as I get it working I'll upload it here.
Changed 10 years ago by juanrgar (Juan R. García Blanco)
| Attachment: | mozjs24-Portfile.tgz added |
|---|
mozjs24 new Portfile
comment:5 follow-up: 9 Changed 10 years ago by juanrgar (Juan R. García Blanco)
I'm not very proud of patch-process.py.diff because I'm not sure of the safety implications of setting SHELL to /bin/bash. I regenerated the DEPLOYMENT_TARGET patch, and added a dependency on xorg-libX11 to get X11/Xlib.h.
comment:6 Changed 10 years ago by dbevans (David B. Evans)
Replying to juanrgar@…:
Oops, I didn't get an email notification of this ticket because I wrote ...@… instead of ...@… in the maintainers entry of mozjs17. I'll cc me now.
I should have been paying more attention!
mozjs17 maintainers field updated in r117087.
comment:7 Changed 10 years ago by dbevans (David B. Evans)
| Cc: | juanrgar@… removed |
|---|---|
| Owner: | changed from juanrgar@… to juanrgar@… |
comment:8 Changed 10 years ago by dbevans (David B. Evans)
mozjs24 committed in r117088. Installs in parallel with mozjs17, no conflict.
comment:9 Changed 10 years ago by dbevans (David B. Evans)
Replying to juanrgar@…:
I'm not very proud of patch-process.py.diff because I'm not sure of the safety implications of setting SHELL to /bin/bash. I regenerated the DEPLOYMENT_TARGET patch, and added a dependency on xorg-libX11 to get X11/Xlib.h.
Probably not an issue with recent OS X releases but if you wanted to be sure you could depend on the MacPorts version of bash (and appropriate path).
comment:10 Changed 10 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Cc Me!