Changes between Initial Version and Version 1 of Ticket #42986, comment 12


Ignore:
Timestamp:
Oct 9, 2014, 12:33:25 AM (10 years ago)
Author:
lubodiakov@…
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #42986, comment 12

    initial v1  
    11Replying to [comment:11 ryandesign@…]:
    22> We don't use variants whose names begin with negative words like "no" anymore. Instead we would have a "pulseaudio" variant and enable it by default, allowing the user to disable it if desired.
    3 OK, I can make the changes for this to the Portfile. I was just trying to keep the changes minimal, this way changes more of it, but no problem.
     3OK, I have made the changes for this to the Portfile. I was just trying to keep the changes minimal, this way changes more of it, but no problem.
    44
    55> Simply removing a dependency is also insufficient. You need to ensure that if the user ''does not request'' pulseaudio support in openal-soft (or rather, requests that pulseaudio support not be provided), that pulseaudio support ''is not provided'', ''even if'' the pulseaudio port is already installed. This is typically accomplished via a configure argument, though it can vary by build system.
    6 This will be more difficult, I'm not familiar with the build system, so I have to find what to configure so it leaves pulseaudio out of the build.
     6CMakeLists.txt inside the source tarball checks which backend is available automatically, and only links to it. The author of openal-soft designed it that way.