Changes between Initial Version and Version 4 of Ticket #43145


Ignore:
Timestamp:
Apr 1, 2014, 4:09:20 PM (10 years ago)
Author:
anddam (Andrea D'Amore)
Comment:

The portgroup cannot possibly know what encoding will the produced Makefile use.

Port p5-yaml is using ExtUtils::MakeMaker that in turn relies on Pod::Man. Pod::Man can produce utf8 Makefiles, search utf8 in in this page but seems that MakeMaker doesn't have any option to specify that, see this request.

Since the portgroup is patching Makefiles we could sanitize the file by adding a new variable specifying a charset to convert from. In this case the portfile writer would specify something like

perl5.makefile_encoding    iso8859-1
perl5.setup         YAML 0.90

and the post-configure phase would take care of convert the file to UTF-8 (or any other target encoding depending on the darwin release) before reinplaces.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #43145

    • Property Cc egall@… added
    • Property Port p5-test-base added
  • Ticket #43145 – Description

    initial v4  
    3131> I mean you could set the correct locale for the file, but then any messages to your terminal would be broken…
    3232
    33 anddam:
    34 > I'd escape that dollar sign
    35 
    3633Dar1us:
    3734> it refuses to process files which aren't validly encoded given the current LC settings