Changes between Initial Version and Version 2 of Ticket #48224


Ignore:
Timestamp:
Jul 2, 2015, 2:37:08 PM (9 years ago)
Author:
larryv (Lawrence Velázquez)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #48224

    • Property Owner changed from macports-tickets@… to cal@…
    • Property Summary changed from potential thinko in ghc Portfile to ghc @7.8.3_2: setting compiler.cpath and compiler.library_path is potential no-op

  • Ticket #48224 – Description

    initial v2  
    11While adapting the MacPorts ghc-bootstrap/ghc to create matching fink packages to build ghc from source for adding rootless support to 7.8.3, I noticed what appears to be a thinko in the current ghc  Portfile. Specially, the section...
    2 
     2{{{
    33# OK so because the bootstrap binary has been prebuilt for libraries
    44# in /usr/lib we search these before macports stuff to prevent
    … …  
    77compiler.cpath /usr/include
    88compiler.library_path /usr/lib
    9 
    10 seems to be a pointless no-op since it adds those directories to the search list *after* the -I and -L entries are processed.
     9}}}
     10seems to be a pointless no-op since it adds those directories to the search list *after* the -I and -L entries are processed.\\
    1111In the fink packaging, it was desired to mimic the upstream ghc binaries as closely as possible so...
    12 
    13         --with-iconv-includes=/usr/include \
    14         --with-iconv-libraries=/usr/lib \
    15 
     12{{{
     13--with-iconv-includes=/usr/include \
     14--with-iconv-libraries=/usr/lib \
     15}}}
    1616was used in concert with
    17 
     17{{{
    1818NoSetCPPFLAGS: true
    1919NoSetLDFLAGS: true
     20}}}
    2021
    2122Interestingly this still required a BuildConflicts on the fink libiconv-dev to prevent a build issue with ghc-pandoc-types...
    22 
     23{{{
    2324[57 of 57] Compiling Text.Pandoc      ( src/Text/Pandoc.hs, dist/build/Text/Pandoc.o )
    2425In-place registering pandoc-1.12.4.2...
    … …  
    3435      _hs_iconv_open in libHSbase-4.7.0.1.a(iconv.o)
    3536ld: symbol(s) not found for architecture x86_64
     37}}}
    3638
    3739In the MacPorts case, since you using...
    38 
    39               --with-iconv-includes=${prefix}/include \
    40               --with-iconv-libraries=${prefix}/lib    \
    41 
     40{{{
     41--with-iconv-includes=${prefix}/include \
     42--with-iconv-libraries=${prefix}/lib    \
     43}}}
    4244and are leaving -I${prefix}/include on configure.cppflags and -L${prefix}/lib on configure.ldflags, the use of...
    43 
     45{{{
    4446compiler.cpath /usr/include
    4547compiler.library_path /usr/lib
    46 
     48}}}
    4749is pointless dead code in the Portfile