Opened 9 years ago

Closed 9 years ago

#49706 closed submission (fixed)

py-swiginac @1.5.1.1 - new port

Reported by: mbrethen Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc:
Port: py-swiginac

Description

Swiginac is a Python interface to GiNaC, built with SWIG. The aim of swiginac is to make all the functionality of GiNaC accessible from Python as an extension module.

Attachments (2)

patch-setup.py.diff (646 bytes) - added by mbrethen 9 years ago.
Portfile (1.9 KB) - added by mbrethen 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: py-swiginac added
Status: newassigned

Thanks.

The construct "eval ... [glob ...]" is deprecated. It was used for Tcl 8.4 compatibility but now that MacPorts uses a bundled copy of Tcl 8.5 on all systems, the expansion operator {*} should be used instead of eval, as in "... {*}[glob ...]". I've added a lint warning for this in r142588.

comment:2 in reply to:  1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to ryandesign@…:

I've added a lint warning for this in r142588.

When the next version of MacPorts from trunk is released, the lint warning would look like this:

$ port lint
--->  Verifying Portfile for py-swiginac
Warning: Line 47 should use the expansion operator instead of the eval procedure. Change
Warning:         eval xinstall -m 644 [glob ${worksrcpath}/doc/swiginac*.*] ${docdir}
Warning: to
Warning:         xinstall -m 644 {*}[glob ${worksrcpath}/doc/swiginac*.*] ${docdir}
Warning: Line 49 should use the expansion operator instead of the eval procedure. Change
Warning:         eval xinstall -m 644 [glob ${worksrcpath}/doc/examples/*.py] \
Warning: to
Warning:         xinstall -m 644 {*}[glob ${worksrcpath}/doc/examples/*.py] \
--->  0 errors and 2 warnings found.

comment:3 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Please attach the file patch-setup.py.diff referenced in the portfile.

Changed 9 years ago by mbrethen

Attachment: patch-setup.py.diff added

comment:4 Changed 9 years ago by mbrethen

The portfile has been updated per your recommendations.

Last edited 9 years ago by mbrethen (previous) (diff)

comment:5 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. The original Portfile included this line:

xinstall -m 644 ${worksrcpath}/doc/html4css1.css ${docdir}

This was removed in your revised Portfile. Was that intentional?

Changed 9 years ago by mbrethen

Attachment: Portfile added

comment:6 Changed 9 years ago by mbrethen

No, clumsy typing. Fixed.

comment:7 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Ok, committed in r142608.

Note: See TracTickets for help on using tickets.