lilypond build fails due to missing reference to libc++ on some Darwin systems - fix attached

[kenneth.f.cunningham@…]

Lily pond fails to build on Snow Leopard with the LibcxxOnOlderSystems upgrade, due to missing reference to libc++. Failed build log attached. Fix Portfile diff also attached, that add reference to libc++ on Darwin Mountain Lion and lower with configure.cxx_stdlib=libc++

[kenneth.f.cunningham@…]

Failed build log of original build attempt.

[kenneth.f.cunningham@…]

Portfile fix to add libc++ reference (diff)

[larryv (Lawrence Velázquez)]

The check seems overzealous. Why bother with version? Just add the flag always.

platform darwin {
    if {${configure.cxx_stdlib} eq "libc++"} {
        configure.ldflags-append    "-lc++"
    }
}

[kenneth.f.cunningham@…]

Thanks.Yes, more general version certainly fine with me, if there's no trouble with adding the reference to systems when not really needed -- was trying to be specific (perhaps overly careful). Presumably this additional library reference is not needed on platforms above mountain lion. Wasn't sure if adding it would cause trouble there. -- K

[nerdling (Jeremy Lavergne)]

Patched in r151452.

[ryandesign (Ryan Carsten Schmidt)]

Can anyone explain why -lc++ is used here instead of the more usual -stdlib=libc++?

Indeed, does this need to be specific to darwin or libc++? Why not just:

configure.ldflags-append -stdlib=${configure.cxx_stdlib}

Has anyone reported this problem to the developers of lilypond so they can fix it in their sources? MacPorts sets -stdlib=whatever in CXXFLAGS, lilypond just seems to be neglecting to use the CXXFLAGS variable when linking C++ code.