Opened 5 years ago

Closed 4 years ago

#52441 closed submission (fixed)

Add dnsviz port

Reported by: cdeccio (Casey Deccio) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cdeccio (Casey Deccio)
Port: dnsviz

Description


Attachments (1)

Portfile (1.2 KB) - added by cdeccio (Casey Deccio) 4 years ago.
Portfile

Download all attachments as: .zip

Change History (8)

comment:1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Thanks. Some comments:

  • Ports for software hosted at GitHub should use the github 1.0 portgroup.
  • For ports that use the python portgroup but that provide apps, not python modules, specify only the single version of python that the port will use (or add variants to let the user choose which version of python they want, if that's important for this port).
  • A dependency on graphviz should be written in path: style so that graphviz-devel could satisfy it.
  • You shouldn't declare a dependency on stub ports, like ports whose names begin with "py-". Instead, depend on the specific python version of that module that you need. Use the ${python.version} variable, as in port:py${python.version}-dnspython

comment:2 in reply to:  1 Changed 5 years ago by cdeccio (Casey Deccio)

Thanks - all done. Please see new Portfile with applied changes.

One minor comment with regard to the following:

  • For ports that use the python portgroup but that provide apps, not python modules, specify only the single version of python that the port will use (or add variants to let the user choose which version of python they want, if that's important for this port).

This makes sense. For what it's worth the documentation is a bit misleading with the use of "default":

... and python.versions defaults to the value of python.default_version ...

(https://guide.macports.org/chunked/reference.portgroup.html)

It does later say "automatically set", but "default" can be confusing even so.

Thanks!

Version 0, edited 5 years ago by cdeccio (Casey Deccio) (next)

comment:3 Changed 4 years ago by cdeccio (Casey Deccio)

Updated Portfile for version 0.6.4.

Changed 4 years ago by cdeccio (Casey Deccio)

Attachment: Portfile added

Portfile

comment:4 Changed 4 years ago by cdeccio (Casey Deccio)

Updated Portfile for version 0.6.5.

comment:5 Changed 4 years ago by cdeccio (Casey Deccio)

Just curious - is a pull request at the github site (https://github.com/macports/macports-ports) preferred to submitting tickets on the trac site for new ports?

comment:6 in reply to:  5 Changed 4 years ago by larryv (Lawrence Velázquez)

Neither is preferred. Use whichever method you are most comfortable with.

Note: See TracTickets for help on using tickets.