Changes between Initial Version and Version 1 of Ticket #53548, comment 4


Ignore:
Timestamp:
Feb 12, 2017, 8:37:57 AM (7 years ago)
Author:
mojca (Mojca Miklavec)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #53548, comment 4

    initial v1  
    1818fi
    1919}}}
     20
     21The code for the two functions is in `mpbb-gather-archives`:
     22* `if ! curl -fIsL "${option_archive_site}/${archive_port}/${archive_basename}" > /dev/null;`
     23* `if "${tclsh}" "${option_jobs_dir}/port_binary_distributable.tcl" -v "${archive_port}"; then`
     24
     25It would be nice to create a standalone shell function to check whether a port is distributable to avoid some code duplication.
     26
     27But we'll have another problem: `install-dependencies` and `install-port` would currently skip installing anything in case the port exists already. And `gather-archives` will only ever upload active ports. Personally I would remove all those checks from `install-dependencies` and `install-port`. I would let the `list-subport` routine do the job of the gatekeeper and build (activate) everything once on the builder.
     28
     29While at this: we probably still have another tiny problem when wine's dependencies get updated and don't get built as universal. But I wouldn't want to activate all ports for the sake of that use case, I would try to solve that in a different way.
     30
     31A quick and dirty hack would be to extend the `if [when (not) to build the port]` and always build ports with non-default architectures (for example `i386` or `universal` on `x86_64`). In that case the buildbot would always build `wine` if somebody triggers that from time to time.