Changes between Initial Version and Version 1 of Ticket #54993, comment 27


Ignore:
Timestamp:
Feb 10, 2018, 5:15:46 PM (6 years ago)
Author:
kencu (Ken)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #54993, comment 27

    initial v1  
    1 so it's this new definition here in `syslog.h`
     1so it appears to be this new definition here in `syslog.h`
    22{{{
    33#if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) && __DARWIN_C_LEVEL >= __DARWIN_C_FULL
    … …  
    99`gcc` accepts the call if  the test sends it to the second definition. I think the `mmacosx-version-min=10.12` makes the first definition work by affecting that `DARWIN_ALIAS_STARTING` macro.
    1010
    11 I assume there is some reason Apple did that. It's not a bug, they did it on purpose.
     11I assume there is some reason Apple did that. They did it on purpose.
    1212
    1313we could add `mmacosx-version-min=10.12` to the `optflags` --- not really an optimization flag, though, is it? So that feels a bit off.
    … …  
    1717Is there something that needs to be written into the wrappers as well?
    1818
    19 And finally, I suppose this is only needed on the `gcc` subports.
     19I suppose this is only needed on the `gcc` subports -- I'll test an openmpi-clang build and see.
     20
     21Also -- this would affect anything build with gcc that uses syslog.h, I suppose, not just openmpi.
     22