diff-pdf @0.3: rebuild fails in configure

[dbevans (David B. Evans)]

After updating poppler to version 0.76.0+, diff-pdf fails as follows:

dbevans$ diff-pdf
dyld: Library not loaded: /opt/local/lib/libpoppler.86.dylib
  Referenced from: /opt/local/bin/diff-pdf
  Reason: image not found

which implies that it needs to be rebuilt with latest poppler 0.77.0 providing /opt/local/lib/libpoppler.88.dylib.

The rebuild fails in configure as follows (from config.log):

configure:3573: checking for wx-config
configure:3576: result: /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config
configure:3628: checking for wxWidgets version >= 3.0.0
configure:3743: result: no
configure:3816: error: wxWidgets is required

although wxWidgets-3.0 is installed and active

dbevans$ port installed wxWidgets-3.0
The following ports are currently installed:
  wxWidgets-3.0 @3.0.4_1 (active)

Apparently, wx-config is not returning the expected result. Not sure if this is a problem with diff-pdf or wxWidgets-3.0 itself so notifying all concerned. Log files attached.

[mojca (Mojca Miklavec)]

What do you get with the following commands?

grep EGREP /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config | grep grep
/opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config --version

[dbevans (David B. Evans)]

dbevans$ grep EGREP /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config | grep grep
EGREP="/opt/local/bin/ggrep -E"

dbevans$ /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config --version

          Warning: No config found to match: /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config --version
                   in /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/wx/config
          If you require this configuration, please install the desired
          library build.  If this is part of an automated configuration
          test and no other errors occur, you may safely ignore it.
          You may use wx-config --list to see all configs available in
          the default prefix.

dbevans$ /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config --list

    Default config is osx_cocoa-unicode-3.0

          No config found to match: /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/bin/wx-config --list
          in /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/wx/config

          Please install the desired library build, or specify a different
          prefix where it may be found.  If the library is not installed
          you may call its wx-config directly by specifying its full path.


  Also available in /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0:
    osx_cocoa-unicode-3.0

[dbevans (David B. Evans)]

Port diff-pdf was added in

commit 8007c8fa32725307ce80df012f9c1c563479f0f7
Author: Piet van Oostrum <piet@vanoostrum.org>
Date:   Wed Feb 13 23:19:38 2019 +0100

    diff-pdf: new Portfile

at which point it built correctly with wxWidgets-3.0. Since then the only commit to wxWidgets-3.0 was

commit 5145438cf253764f9f39b29dda2af5821ed6872c
Author: Mojca Miklavec <mojca@macports.org>
Date:   Sat Mar 9 19:08:37 2019 +0100

    wxWidgets-3.0: add upstream patch for strings
    
    See: https://trac.wxwidgets.org/ticket/18355
    See: https://github.com/wxWidgets/wxWidgets/pull/1251
    See: https://github.com/macports/macports-ports/pull/3804

I initially tried to rebuild diff-pdf with poppler 0.76.0 in

commit 26d165669bf7e96644a81377748abc461a710e76
Author: David B. Evans <devans@macports.org>
Date:   Sun Mar 24 22:32:13 2019 -0700

    poppler: rebuild dependents that link with core libpoppler
    
    See PR https://github.com/macports/macports-ports/pull/3926.

which resulted in failure as described here.

[dbevans (David B. Evans)]

@mojca: I just reinstalled wxWidgets-3.0 @3.0.4_0 from the commit before ​5145438cf253764f9f39b29dda2af5821ed6872c and I was able to build diff-pdf successfully so I guess that's where the problem is.

[mojca (Mojca Miklavec)]

My guess is that you don't have /opt/local/bin/ggrep installed as you probably ran port reclaim in the meantime?

See comment:5:ticket:57508. I thought I fixed it, but apparently I was waiting for some feedback and forgot about it.

[pietvo (Pieter van Oostrum)]

I did a 'port selfupdate; port upgrade outdated' some days ago. It upgraded popper from 0.76.1_0 to 0.77.0_0 and then discovered that diff-pdf had to be rebuilt. And that succeeded without problems. This is on MacOS 10.13.6. But I do have /opt/local/bin/ggrep. Apparently I have requested it, and also it is a dependency of p5.26-config-autoconf, which isn't necessary anymore in my installation, but which I have requested also (apparently). So if I do some cleanup in this area it could easily break diff-pdf in my installation too.

[dbevans (David B. Evans)]

Replying to mojca:

My guess is that you don't have /opt/local/bin/ggrep installed as you probably ran port reclaim in the meantime?

Indeed. Activating grep (which now installs ggrep) fixed the problem and diff-pdf builds without any problems. So, as discussed in the referenced ticket, some usable form of grep needs to be declared as a lib dependency and explicitly configured for use in wxWidgets-3.0 so that it is available during both build and at runtime. I've got no preference as to using port grep or the system version so will leave the fix to you. Thanks.

Closing this ticket as a duplicate of the underlying issue in #57508.