Changes between Version 4 and Version 5 of Ticket #59644, comment 5


Ignore:
Timestamp:
Dec 15, 2019, 8:14:53 AM (4 years ago)
Author:
Ionic (Mihai Moldovan)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #59644, comment 5

    v4 v5  
    33(Although, strictly speaking, if the moc bug is the only requirement for 5.9+, then we could revert the check back to the older value and fix up the build to not try to parse that file with moc - reenabling the GUI for older platforms. Processing a header with moc is only really needed for Qt objects and signals and slots, so in theory excluding that file should work.
    44
    5 I looked into the repository and found out that the earlier version was compatible Qt 5.4+. They removed a bit of compatibility code with the newest release when bumping the requirement up to 5.9+, so it's not just fixing a moc issue. We probably don't want to maintain a GUI modification patch set and upstream seems to not be interested in supporting older versions, so that won't work...)
     5I looked into the repository and found out that the earlier version was compatible with Qt 5.4+. They removed a bit of compatibility code with the newest release when bumping the requirement up to 5.9+, so it's not just fixing a moc issue. We probably don't want to maintain a GUI modification patch set and upstream seems to not be interested in supporting older versions, so that won't work...)