Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#60618 closed defect (fixed)

legacy-support: which replacement on Tiger not fully functional

Reported by: kencu (Ken) Owned by: kencu (Ken)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Tiger Cc: cjones051073 (Chris Jones), miniupnp (Thomas BERNARD)
Port: legacy-support legacy-support-devel

Description

On Tiger, the which command has been modified slightly in legacy-support to make it match newer systems, to allow Makefiles and shell scripts to work as expected. It appears there is still some work to do on this.

This command, for example, functions correctly with a newer system which:

$ which autoconf-2.13 autoconf2.13 autoconf213
/opt/local/bin/autoconf213

but using our modified Tiger which, it doesn't function as expected:

/opt/macports-legacy-support/tiger_only/bin/which autoconf-2.13 autoconf2.13 autoconf213

-- returns nothing --

The which command on Tiger is a simple shell script, so hopefully won't be terribly hard to fix properly.

PS -- if you're interested, the which command in legacy-support is available here to try on any system <https://github.com/macports/macports-legacy-support/blob/master/tiger_only/bin/which>

Change History (6)

comment:1 Changed 4 years ago by kencu (Ken)

This commit added the exit 1 and this is what broke it.

[484b4a33f8b9d34120f7b8697d81aa30a3cd4eaf/macports-legacy-support]

Last edited 4 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:2 Changed 4 years ago by kencu (Ken)

Cc: miniupnp added

comment:3 Changed 4 years ago by kencu (Ken)

Ping Thomas for thoughts. Presumably that exit 1 needs to be managed a bit differently.

comment:4 Changed 4 years ago by kencu (Ken)

These both have to work -- System:

$ which autoconf-2.13 || which autoconf2.13 || which autoconf213
/opt/local/bin/autoconf213

$ which autoconf-2.13 autoconf2.13 autoconf213
/opt/local/bin/autoconf213

ours:

$ /opt/macports-legacy-support/tiger_only/bin/which autoconf-2.13 || /opt/macports-legacy-support/tiger_only/bin/which autoconf2.13 || /opt/macports-legacy-support/tiger_only/bin/which autoconf213
/opt/local/bin/autoconf213

$ /opt/macports-legacy-support/tiger_only/bin/which autoconf-2.13 autoconf2.13 autoconf213
Version 0, edited 4 years ago by kencu (Ken) (next)

comment:5 Changed 4 years ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed

comment:6 Changed 4 years ago by miniupnp (Thomas BERNARD)

@kencu : sorry for my lack of responsiveness. You fix is perfect !

Note: See TracTickets for help on using tickets.