Changes between Initial Version and Version 1 of Ticket #61282, comment 12


Ignore:
Timestamp:
Mar 4, 2021, 8:12:23 AM (3 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #61282, comment 12

    initial v1  
    1 It looks like python's build system must do some kind of word wrapping when it creates the file _sysconfigdata!__darwin_darwin.py. The Portfile uses `reinplace` to remove `-arch` flags from _sysconfigdata!__darwin_darwin.py (see #39669 where that was first added) but because my `CFLAGS` are longer, some of the `-arch` flags happen to end up broken across multiple lines due to the word wrapping, so `reinplace` doesn't remove all of them. (Even in the default build, it doesn't remove all of them—look at `CONFIGURE_CFLAGS`, `PY_CORE_CFLAGS`, and `PY_STDMODULE_CFLAGS`.) Here's the diff between how that file got generated in a standard "vanilla" build and how it got generated with `-Werror=implicit-function-declaration` added:
     1It looks like python's build system must do some kind of word wrapping when it creates the file _sysconfigdata!__darwin_darwin.py (perhaps to comply with [https://www.python.org/dev/peps/pep-0008/#maximum-line-length PEP-8]). The Portfile uses `reinplace` to remove `-arch` flags from _sysconfigdata!__darwin_darwin.py (see #39669 where that was first added) but because my `CFLAGS` are longer, some of the `-arch` flags happen to end up broken across multiple lines due to the word wrapping, so `reinplace` doesn't remove all of them. (Even in the default build, it doesn't remove all of them—look at `CONFIGURE_CFLAGS`, `PY_CORE_CFLAGS`, and `PY_STDMODULE_CFLAGS`.) Here's the diff between how that file got generated in a standard "vanilla" build and how it got generated with `-Werror=implicit-function-declaration` added:
    22
    33{{{#!diff