Changes between Initial Version and Version 1 of Ticket #64341, comment 7


Ignore:
Timestamp:
Jan 4, 2022, 7:37:30 AM (2 years ago)
Author:
kencu (Ken)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #64341, comment 7

    initial v1  
    22> So it's the same situation as #60419. Apparently both the submitter and reviewers failed to notice the comment in the libpsl Portfile when handling [https://github.com/macports/macports-ports/pull/9941 PR #9941].
    33
    4 So my apologies for committing that PR, but perhaps it was a bit of a high bar to expect that this PR view
     4My apologies for committing that PR. Perhaps it was a bit of a high bar to expect that this PR view
    55
    66https://github.com/macports/macports-ports/pull/9941/commits/c87a5f7729fd825f1f1ea305999c5298c7ef2db2
    77
    8 with all the tests passing, would lead to an insight that there was a missing instruction somewhere in the python Portfile to add a clang dependency. If that is the expectation (and apparently it is) then it is easy to see why very few people agree to try committing PRs :>
     8with all the tests passing, would lead to insight that there was a missing instruction in the python Portfile to add a clang dependency.
    99
    10 The note is more obvious now, but still not very clear what needs to be done, to be honest (ie check that the new python being used has the clang-dependency PG added).
     10The note is more obvious now.
    1111
    12 The suggestion I made to use cmake-bootstrap  (which has no deps)  to build the clangs would simplify this considerably, at least up until whichever clang can no longer be built with the the cmake version in cmake-bootstrap.
     12The suggestion I made to use cmake-bootstrap  (which has no deps)  to build the clangs may simplify this process.