| 1 | | For MacPorts to accept a fix into either base or into a Portfile, it has to be what you would call a "pure, true fix". Anything else is, in the long run, going to be more trouble than it is worth. |
| 2 | | |
| 3 | | You can see many many many examples all throughout the PRs and tickets and discussion lists from people who have found some workaround or another for their build or install problem that works for them on the machine they have in front of them. |
| 4 | | |
| 5 | | No argument about that, and more power to them! They have something that works for them. |
| 6 | | |
| 7 | | The problem comes when they want to share their proudly-discovered HACK with the world. Hacks like that almost always wind up being a big disaster in the end, once the build spreads to more systems, newer systems, other systems, etc. They cause a LOT of headaches. |
| 8 | | |
| 9 | | I have been guilty of this myself at times, for sure. There are a number of HACK PRs in the PR queue now that will probably never be allowed into MacPorts, nor should they be. |
| 10 | | |
| 11 | | So -- what you have found here works for you. That is great. |
| 12 | | |
| 13 | | It will never be allowed into MacPorts like this, though, nor should it be. |
| 14 | | |
| 15 | | That is great too! |
| | 1 | For MacPorts to accept a fix into either base or into a Portfile, it generally has to be what you would call a "pure, true fix". Anything else is, in the long run, going to be more trouble than it is worth. |
