Changes between Initial Version and Version 1 of Ticket #64677


Ignore:
Timestamp:
Feb 16, 2022, 5:08:13 PM (2 years ago)
Author:
barracuda156
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #64677

    • Property Summary changed from libass fix for PowerPC to libass fix for PowerPC (please close the ticket, fix unneeded)

  • Ticket #64677 – Description

    initial v1  
    1 1. Portfile must invoke `macports-gcc-7`, as `gcc-4.2` fails to build it.
    2 Adding this works:
     1UPD. Sorry, it failed before due to unrelated problem, it seems. It does build with gcc7:
     2
    33
    44{{{
    5 compiler.whitelist macports-gcc-7
     536-47:~ svacchanda$ port -v installed libass
     6The following ports are currently installed:
     7  libass @0.15.2_0 (active) requested_variants='-universal' platform='darwin 9' archs='ppc' date='2022-02-17T01:04:05+0800'
    68}}}
    7 
    8 Otherwise (and perhaps better) we can just ban `gcc-4.0` and `gcc-4.2`.
    9 
    10 2. There is one problem with the source in `ass_coretext.c`:
    11 
    12 {{{
    13 static bool is_postscript_font_format(CFNumberRef cfformat)
    14 {
    15     bool ret = false;
    16     int format;
    17     if (CFNumberGetValue(cfformat, kCFNumberIntType, &format)) {
    18         ret = format == kCTFontFormatOpenTypePostScript ||
    19               format == kCTFontFormatPostScript;
    20     }
    21     return ret;
    22 }
    23 }}}
    24 
    25 Once kCTFontFormatOpenTypePostScript is removed, libass builds. I am not sure it is an optimal fix though.
    26 Opened a ticket here: https://github.com/libass/libass/issues/595