rust ports: link crashes across macOS releases

[mascguy (Christopher Nielsen)]

Link crashes are occurring for multiple ports, across macOS releases. They typically look something like this:

  = note: 0  0x106522b51  __assert_rtn + 144
1070	          1  0x106553063  ld::Fixup::Fixup(unsigned int, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 107
1071	          2  0x10652b4e9  mach_o::relocatable::Parser<x86_64>::addFixup(mach_o::relocatable::Parser<x86_64>::SourceLocation const&, ld::Fixup::Cluster, ld::Fixup::Kind, bool, char const*) + 33
1072	          3  0x106526751  mach_o::relocatable::Section<x86_64>::addRelocFixup(mach_o::relocatable::Parser<x86_64>&, macho_relocation_info<Pointer64<LittleEndian> > const*) + 1471
1073	          4  0x10654ebb7  mach_o::relocatable::Section<x86_64>::makeFixups(mach_o::relocatable::Parser<x86_64>&, mach_o::relocatable::Parser<x86_64>::CFI_CU_InfoArrays const&) + 91
1074	          5  0x10654a7c6  mach_o::relocatable::Parser<x86_64>::parse(mach_o::relocatable::ParserOptions const&) + 2034
1075	          6  0x10652e0fd  mach_o::relocatable::Parser<x86_64>::parse(unsigned char const*, unsigned long long, char const*, long, ld::File::Ordinal, mach_o::relocatable::ParserOptions const&) + 375
1076	          7  0x10655e9cc  archive::File<x86_64>::makeObjectFileForMember(archive::File<x86_64>::Entry const*) const + 758
1077	          8  0x10655e518  archive::File<x86_64>::justInTimeforEachAtom(char const*, ld::File::AtomHandler&) const + 122
1078	          9  0x10657419b  ld::tool::InputFiles::searchLibraries(char const*, bool, bool, bool, ld::File::AtomHandler&) const + 215
1079	          10  0x10657cc90  ld::tool::Resolver::resolveUndefines() + 160
1080	          11  0x10657ef63  ld::tool::Resolver::resolve() + 79
1081	          12  0x1065236c7  main + 689
1082	          13  0x10688e5fd  start + 1
1083	          A linker snapshot was created at:
1084	          /tmp/build_script_build-100b7420c9437e43-2022-06-04-173157.ld-snapshot
1085	          ld: Assertion failed: (name != NULL), function Fixup, file /SourceCache/ld64/ld64-241.9/src/ld/ld.hpp, line 510.
1086	          clang: error: linker command failed with exit code 1 (use -v to see invocation)
1087	

The current list of affected ports includes:

• cargo-c: link crash on 10.6_x86_64
• libopenraw: link crash on multiple macOS releases

[cjones051073 (Chris Jones)]

Its not obvious to me clang-13 is the ssiue here. If you check the log more closely I believe the seg. is coming from rust.

[cjones051073 (Chris Jones)]

@mascguy - Can you check the log you uploaded. its difficult to read as its got a bunch of html mixed in. Can you please make it a simple plain text file ?

[mascguy (Christopher Nielsen)]

Replying to cjones051073:

@mascguy - Can you check the log you uploaded. its difficult to read as its got a bunch of html mixed in. Can you please make it a simple plain text file ?

Fixed. And ignore the second version, forgot to check the box to replace the existing file. (Though both are identical anyway.)

[mascguy (Christopher Nielsen)]

In any case, the log is from our 10.9 buildbot. Simply wanted to attach it to the ticket, to preserve the detail once it ages out.

​https://ports.macports.org/port/libopenraw/details/

[mascguy (Christopher Nielsen)]

Replying to cjones051073:

Its not obvious to me clang-13 is the ssiue here. If you check the log more closely I believe the seg. is coming from rust.

Well, the link failure is only occurring on macOS 10.10 and earlier. So does that mean rust only has issues on those macOS releases...?

[cjones051073 (Chris Jones)]

I guess so, yes.

[jmroot (Joshua Root)]

Replying to mascguy:

the log is from our 10.9 buildbot.

Append /text to the URL to get a plaintext version.