Changes between Version 1 and Version 2 of Ticket #66833, comment 2


Ignore:
Timestamp:
Feb 5, 2023, 1:50:53 AM (15 months ago)
Author:
jmroot (Joshua Root)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #66833, comment 2

    v1 v2  
    1 Hm, or maybe just a mismatch of expectations with what this port is doing. The distfile `go-ipfs-source.tar.gz` contains a directory called `ipfs-kubo-0.18.1`. The Portfile sets `extract.dir ${workpath}/${go.author}-${go.project}-${version}` presumably in an attempt to extract to a different directory, but that's not really what that does, it just controls what is the current working directory when the extract command is run. And then the github portgroup is used, which defaults to `extract.rename yes`, which renames the extracted directory to `$distname`. The portgroup expects to find either `${workpath}/${go.author}-${go.project}-*`, `${workpath}/${go.project}`, or `${workpath}/${go.project}-*`.
     1Hm, or maybe partially a mismatch of expectations with what this port is doing. The distfile `go-ipfs-source.tar.gz` contains the source with no enclosing directory. Normally you'd set `extract.mkdir` to handle this, but the portgroup sets `worksrcdir` to `gopath/src/${go.package}` while also expecting the source to initially not be in there (`extract.mkdir` creates `$worksrcdir` for you and extracts the source inside it). The Portfile sets `extract.dir ${workpath}/${go.author}-${go.project}-${version}` presumably in an attempt to extract to a different directory, but that's not really what that does, it just controls what is the current working directory when the extract command is run. And then the github portgroup is used, which defaults to `extract.rename yes`, which renames the extracted directory to `$distname`. The portgroup expects to find either `${workpath}/${go.author}-${go.project}-*`, `${workpath}/${go.project}`, or `${workpath}/${go.project}-*`.
     2
     3Seems like the portgroup is being a bit too clever for its own good, and should just do nothing if the source is already in the correct place in `$worksrcdir`.