Changes between Initial Version and Version 1 of Ticket #67504


Ignore:
Timestamp:
May 26, 2023, 4:31:41 AM (12 months ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Excuse me, looking at the logs I see that the function names are still in quotes. 

% grep -E ' implicit|call to undeclared' config.log.*
config.log.clang15:conftest.c:62:6: warning: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:150:5: warning: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:144:7: warning: call to undeclared library function 'strcmp' with type 'int (const char *, const char *)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:145:5: warning: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:167:5: warning: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:174:23: warning: call to undeclared function 'pthread_condattr_setclock'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:174:1: warning: call to undeclared function 'pthread_cond_timedwait_monotonic'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.clang15:conftest.c:174:1: warning: call to undeclared function 'pthread_cond_timedwait_monotonic_np'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:62:6: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:62:6: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:62:6: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:149:5: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:142:7: error: implicitly declaring library function 'strcmp' with type 'int (const char *, const char *)' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:143:5: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:164:5: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:170:23: error: implicit declaration of function 'pthread_condattr_setclock' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:170:1: error: implicit declaration of function 'pthread_cond_timedwait_monotonic' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
config.log.xcode13:conftest.c:170:1: error: implicit declaration of function 'pthread_cond_timedwait_monotonic_np' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #67504 – Description

    initial v1  
    5151
    5252{{{
    53 error: call to undeclared library function '…' with type …; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     53error: call to undeclared library function '…' with type '…'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    5454}}}
    5555and
    5656{{{
    57 error: call to undeclared function …; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     57error: call to undeclared function '…'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    5858}}}
    5959
    60 Our code currently [https://github.com/macports/macports-base/blob/82b064968d0ae5561911b850249939a7f77ae158/src/port1.0/portconfigure.tcl#LL1879C73-L1879C110 searches only for the regular expression] `(?:implicit declaration of function|implicitly declaring library function) '(\[^']+)'` in config.log. This will have to be extended to catch the new wording as well, noting that in the new wording the function name is not in quotation marks in one of the messages. Perhaps we should structure the regexp so that it can work whether or not the function names are in quotes, in case they change one or the other message in the future for consistency.
     60Our code currently [https://github.com/macports/macports-base/blob/82b064968d0ae5561911b850249939a7f77ae158/src/port1.0/portconfigure.tcl#LL1879C73-L1879C110 searches only for the regular expression] `(?:implicit declaration of function|implicitly declaring library function) '(\[^']+)'` in config.log. This will have to be extended to catch the new wording as well, ~~noting that in the new wording the function name is not in quotation marks in one of the messages. Perhaps we should structure the regexp so that it can work whether or not the function names are in quotes, in case they change one or the other message in the future for consistency.~~
    6161
    6262We probably have to update the documentation in WimplicitFunctionDeclaration too.