Changes between Version 18 and Version 19 of NewCommittersGuide

Timestamp:

Jun 16, 2009, 7:44:36 PM (15 years ago)

Author:

blb@…

Comment:

Add piece about whitespace changes needing to be separate

NewCommittersGuide

@@ -12 +12 @@
    1. You need to change your email address for your ports
    1. Other, similar reasons
+ 1. When changing the whitespace of a Portfile, do so in a separate commit (without any functional changes) as otherwise the commingling of functional and whitespace changes makes reviewing diffs difficult
  1. All committers must subscribe to the [http://lists.macosforge.org/mailman/listinfo/macports-changes macports-changes] list under their MacPorts credentials to keep track of current changes and because the list is subscriber-post-only, so commit messages will otherwise be rejected
  1. New top-level categories (those which are represented by subdirectories directly beneath dports/) need to be approved prior to adding; secondary categories (the second and later ones listed on the '''categories''' Portfile key) can be added when it makes sense (since these really only show under the web interface, and do not necessarily have a filesystem representation)