Changes between Version 27 and Version 28 of NewCommittersGuide

Timestamp:

Nov 1, 2016, 9:18:13 PM (7 years ago)

Author:

raimue (Rainer Müller)

Comment:

Adapt for use with Git and GitHub

NewCommittersGuide

@@ -5 +5 @@
 == Port Committer Responsibilities ==
 
- 1. Do not touch PortIndex. It is updated automatically every hour
  1. A commit affects one port
- 1. An exception to 2. would be several Portfiles making use of some feature which requires an update
+ 1. An exception to the rule above would be several Portfiles making use of some feature which requires an update
    1. A new feature has been released which obsoletes previous hacks
    1. A command or option is found to be broken
-   1. Combined updates for similar ports (py25-* and py26-*)
+   1. Combined updates for similar ports (wine and wine-devel)
    1. Changing maintainer email address for your ports
    1. Other, similar reasons
  1. Make whitespace changes in a separate commit. To keep diffs readable for review whitespace changes should be done in a separate commit without any functional changes.
- 1. New top-level categories (those which are represented by subdirectories directly beneath dports/) need to be approved prior to adding; secondary categories (the second and later ones listed on the '''categories''' Portfile key) can be added when it makes sense (since these really only show under the web interface, and do not necessarily have a filesystem representation)
+ 1. New top-level categories (those which are represented by directories directly beneath the repository root) need to be approved prior to adding; secondary categories (the second and later ones listed on the '''categories''' Portfile key) can be added when it makes sense (since these really only show under the web interface, and do not necessarily have a filesystem representation)
  1. Port directory name has to match the ''name'' option in the Portfile
  1. Run `port lint` before committing to be sure not to violate one of the guidelines
@@ -20 +19 @@
  1. Under most circumstances, do not modify a port belonging to another maintainer; this is to be done either via a Trac ticket or by direct communication with the maintainer.  Exceptions are:
    1. When a port is broken (and the update should be just to fix the port, no other updates "while you're there")
-   1. When ''nomaintainer@macports.org'' is the maintainer; this really means the port is unowned (feel free to take it over)
-   1. When ''openmaintainer@macports.org'' is co-maintainer; this signifies that the primary maintainer has no prior objections to others changing it
+   1. When ''!nomaintainer@macports.org'' is the maintainer; this really means the port is unowned (feel free to take it over)
+   1. When ''!openmaintainer@macports.org'' is co-maintainer; this signifies that the primary maintainer has no prior objections to others changing it
    1. When the maintainer says the update is okay and asks you to commit your update; in this case, be sure to note in the commit message that it was approved by the maintainer
    1. When a ticket was already filed and you're making use of the [http://guide.macports.org/#project.update-policies.nonmaintainer maintainer timeout], note this fact in your commit message and add the ticket id for reference.
- 1. Set up automatic properties for Subversion, as described on the [wiki:CommittersTipsAndTricks#SetsvnpropertiesautomaticallyonnewPortfiles Committers Tips and Tricks] wiki page.
 
 == Mailing Lists and Change Logs ==
 
-Notification of change logging is either via the [http://lists.macosforge.org/mailman/listinfo/macports-changes macports-changes] list or by subscribing to the RSS feeds provided by trac (see the RSS feeds of the [/projects/macports/timeline Timeline view] and the [/projects/macports/log/trunk Source Repository]). Note that you may customize the Timeline prior to subscribing to it, in order to control which types of information you are fed. In addition to getting an RSS feed of [wiki:TracTimeline general project events], you may also subscribe to changes to some [wiki:TracBrowser portion of the source tree] or to [wiki:TracQuery bug reports/tickets].
+Notification of changes is either via the [http://lists.macosforge.org/mailman/listinfo/macports-changes macports-changes] list or by subscribing to the RSS feeds provided by Trac (see the RSS feeds of the [/timeline Timeline view] and the [/log Git Repositories]). Note that you may customize the Timeline prior to subscribing to it, in order to control which types of information you are fed. In addition to getting an RSS feed of [wiki:TracTimeline general project events], you may also subscribe to changes to some [wiki:TracBrowser portion of the source tree] or to [wiki:TracQuery bug reports/tickets].
 
 If you use a newsreader such as [http://www.newsgator.com/NGOLProduct.aspx?ProdID=NetNewsWire NetNewsWire], and if you subscribe to the https version of the feed, you must ensure that you trust the certificate svn.macports.org from the certificate authority opensource.apple.com. You can tell Safari to "trust" this certificate when it sees it; you may need to set the trust settings for the certificate and/or authority from within Keychain access. Without these trust settings, NetNewsWire will not receive the feed. A better solution is to make sure that you subscribe to the http version of the feed (change the scheme on the URL to http from https).
 
-== Checking out from subversion for committing ==
+== Checking out repos for committing ==
 
-See the [wiki:GetMacPortsSource#CheckingoutMacPortssourcesusingSubversion svn section of getting the source] on the URL and proper options for svn.
+See the [wiki:WorkingWithGit] wiki page.
 
 == Committer Addresses ==