New Ticket     Tickets     Wiki     Browse Source     Timeline     Roadmap     Ticket Reports     Search

Ticket #13684 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

PATCH: removed deprecated 'cd' usage from from devel/boost

Reported by: freespace+macforge@… Owned by: sanchom@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: boost,1.7.0,cd Cc: sanchom@…, ryandesign@…
Port: boost

Description (last modified by mcalhoun@…) (diff)


Attachments

boost.patch (2.2 KB) - added by freespace+macforge@… 5 years ago.
svn diff

Change History

Changed 5 years ago by freespace+macforge@…

svn diff

comment:1 Changed 5 years ago by raimue@…

  • Cc sanchom@… added

CC'ing maintainer.

comment:2 Changed 5 years ago by ryandesign@…

Has duplicate #13040.

comment:3 Changed 5 years ago by sanchom@…

This patch looks good. Please apply it.

comment:4 Changed 5 years ago by ryandesign@…

  • Owner changed from macports-tickets@… to ryandesign@…

comment:5 Changed 5 years ago by ryandesign@…

I applied the patch in r33914. But I would still like to see another patch to remove the use of "system" for making symlinks. We have a tcl procedure "ln" to make symlinks so it should not be necessary to call out to "system" for this. For example instead of

system "cd  ${destroot}${prefix}/lib;ln -s ${lib} ${liblink}"

it should be

ln -s ${lib} ${destroot}${prefix}/lib/${liblink}

comment:6 Changed 5 years ago by ryandesign@…

  • Cc ryandesign@… added
  • Owner changed from ryandesign@… to sanchom@…

comment:7 Changed 4 years ago by mcalhoun@…

  • Status changed from new to closed
  • Resolution set to fixed
  • Description modified (diff)

As of r43281, there are no more unnecessary calls to system.

comment:8 Changed 4 years ago by mcalhoun@…

  • Port set to boost
  • Description modified (diff)

Sorry, didn't mean to change the description (it was blank before).

comment:9 Changed 4 years ago by anonymous

  • Milestone Port Bugs deleted

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.