tktable: build fails on Mountain Lion, error: incomplete definition of type 'struct _XDisplay'

[lpsinger (Leo Singer)]

tktable fails to build on Mountain Lion with the following error message:

See attached build log.

[lpsinger (Leo Singer)]

Oops, sorry. I forgot to paste the error message. Here it is:

./generic/tkTable.c:3809:5: error: incomplete definition of type 'struct _XDisplay'
    XSync(tablePtr->display, False);
    ^     ~~~~~~~~~~~~~~~~~
./generic/tkTable.h:75:39: note: expanded from macro 'XSync'
#       define XSync(display, bool) {display->request++;}
                                            ^
/opt/local/include/X11/Xlib.h:263:8: note: forward declaration of 'struct _XDisplay'
struct _XDisplay;               /* Forward declare before use for C++ */
       ^

[cooljeanius (Eric Gallager)]

What does port provides /opt/local/include/X11/Xlib.h return for you? What's the status of the port returned?

[lpsinger (Leo Singer)]

$ port provides /opt/local/include/X11/Xlib.h
/opt/local/include/X11/Xlib.h is provided by: xorg-libX11

[rct@…]

I fixed this problem by building the tk package with +x11.

[lpsinger (Leo Singer)]

Could we have a require_active_variants added to tktable?

[mf2k (Frank Schima)]

markd has retired. See #44782.

[chrstphrchvz (Christopher Chavez)]

See #56807: It would be ideal if this could be used with both tk +quartz and +x11, as has been possible with a few other Tk extensions.

[chrstphrchvz (Christopher Chavez)]

tktable seems to build with tk +quartz 8.6.8 and 8.6.9 on 10.14 Mojave, but I wonder if I have extra port(s) present that happen to let it build. With trace mode, the build fails because it doesn't find Xatom.h:

In file included from ./generic/tkTableTag.c:14:
./generic/tkTable.h:25:11: fatal error: 'X11/Xatom.h' file not found
# include <X11/Xatom.h>
          ^~~~~~~~~~~~~
In file included from ./generic/tkTableWin.c:15:
./generic/tkTable.h:25:11: fatal error: 'X11/Xatom.h' file not found
# include <X11/Xatom.h>
          ^~~~~~~~~~~~~
In file included from ./generic/tkTable.c:25:
./generic/tkTable.h:25:11: fatal error: 'X11/Xatom.h' file not found
# include <X11/Xatom.h>
          ^~~~~~~~~~~~~
In file included from ./generic/tkTableEdit.c:14:
./generic/tkTable.h:25:11: fatal error: 'X11/Xatom.h' file not found
# include <X11/Xatom.h>
          ^~~~~~~~~~~~~
…
Warning: The following existing file was hidden from the build system by trace mode:
  /opt/local/include/X11/Xatom.h

Tktable appears usable on tk +quartz, but I'm inclined to think this is an erroneous/unsafe result.

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

In 694f35aff81d3c4d24cc743471e4c5a7b29c58ad/macports-ports (master):

tktable: don't use X11 headers with tk +quartz

Fixes #38238