#40615 closed enhancement (fixed)
clang-3.4 @3.4-r189956_1 Please include clang-format and clang-modernize
| Reported by: | acmorrow (Andrew C. Morrow) | Owned by: | jeremyhu (Jeremy Huddleston Sequoia) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | pope (K. Adam Christensen), Raimondi (Israel Chauca Fuentes), mamoll (Mark Moll), akimd (Akim Demaille), cdeil (Christoph Deil), hahn.seb@…, john@…, dsvensson@…, larryv (Lawrence Velázquez), dcecchin@…, myint (Steven Myint) | |
| Port: | clang-3.4 |
Description
These clang tools should be either be bundled with clang-3.4, or perhaps placed into separate ports. Either way though, they are very useful and it would be good to see them made available in the MacPorts clang environment.
Attachments (2)
Change History (26)
comment:1 Changed 11 years ago by mf2k (Frank Schima)
| Owner: | changed from macports-tickets@… to jeremyhu@… |
|---|---|
| Version: | 2.2.0 |
Changed 10 years ago by hahn.seb@…
| Attachment: | macports_clang-format.patch added |
|---|
comment:11 follow-up: 12 Changed 10 years ago by hahn.seb@…
I attached a patch to add a new variant called "format". It places the helper scripts into $prefix/libexec/llvm-3.4/libexec/clang-format/ and the clang-format binary is in $prefix/bin and called clang-format-mp-3.4
comment:12 follow-up: 14 Changed 10 years ago by larryv (Lawrence Velázquez)
| Cc: | larryv@… added |
|---|
There’s no good reason to provide this as a variant. Might as well install them unconditionally.
comment:13 follow-up: 15 Changed 10 years ago by dsvensson@…
hanh.seb: How do I use that patch locally?
comment:14 Changed 10 years ago by hahn.seb@…
Replying to larryv@…:
There’s no good reason to provide this as a variant. Might as well install them unconditionally.
Some of the bundled scripts require python27, which the port doesn't require already. That's why I didn't make it unconditionally.
comment:15 Changed 10 years ago by hahn.seb@…
Replying to dsvensson@…:
hanh.seb: How do I use that patch locally?
That's a bit complicated, but you can find info on that in the macports guide at https://guide.macports.org/
comment:16 Changed 10 years ago by dsvensson@…
I just hacked the Portfile in /opt/... instead, since I wanted it for llvm-3.5. Thanks, hopefully it'll be merged before I need to update that port again.
comment:17 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Please just update the patch to address larryv's comment (no need for the variant), and I'll get it in.
Changed 10 years ago by hahn.seb@…
| Attachment: | macports_clang-format-v2.patch added |
|---|
comment:18 Changed 10 years ago by hahn.seb@…
hrm, it seems notifications are not sent out for attached files, sorry. See above for changed patch.
comment:20 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Note to self, do #42913 at the same time.
comment:22 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:24 Changed 3 months ago by slarew
| Cc: | slarew removed |
|---|
In the future, please Cc the port maintainers (
port info --maintainers clang-3.4).