#43839 closed enhancement (fixed)
Clang 3.x: please include clang-modernize
| Reported by: | mamoll (Mark Moll) | Owned by: | jeremyhu (Jeremy Huddleston Sequoia) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | clang-3.4 clang-3.5 |
Description
See #40615.
Attachments (1)
Change History (10)
comment:1 follow-up: 3 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
comment:2 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
As I said there, I don't intend to fix this myself, but if someone wants it, I'll accept a patch.
comment:3 Changed 10 years ago by mamoll (Mark Moll)
Replying to jeremyhu@…:
Yes, see #40615. I said to file a new ticket if you had a patch to go along with it ;)
I missed the patch part ;-). It turns out that clang-modernize is a separate download. It's not too tricky to add it to the build, though. The attached patch adds clang-modernize to clang-3.4 and clang-3.5.
comment:4 Changed 10 years ago by mamoll (Mark Moll)
Wait, this doesn't work yet. Another tool needs to be included as well. Let me update the patch and test it some more.
Changed 10 years ago by mamoll (Mark Moll)
| Attachment: | clang-modernize.diff added |
|---|
comment:6 Changed 10 years ago by mf2k (Frank Schima)
| Keywords: | haspatch added |
|---|---|
| Port: | clang-3.4, clang-3.5 → clang-3.4 clang-3.5 |
| Resolution: | wontfix |
| Status: | closed → reopened |
| Version: | 2.3.0 |
comment:7 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Thanks. I'll test this soon. I'll have another reason to bump 3.4 and 3.5 shortly and will roll this in with those changs.
comment:8 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
Yes, see #40615. I said to file a new ticket if you had a patch to go along with it ;)