Opened 14 years ago

Closed 12 years ago

#10768 closed defect (fixed)

BUG: port - dependency passes by inexisting ports

Reported by: yves@… Owned by: kballard (Lily Ballard)
Priority: High Milestone: MacPorts 1.7.0
Component: base Version:
Keywords: dependency haspatch Cc: markd@…, ghosthound, jmroot (Joshua Root)
Port:

Description

I just found out that if a port: depends is targetted at a port that does not exists, the build will go on as if all was ok.

stange behaviour ...

Attachments (1)

bad_dep.diff (497 bytes) - added by jmroot (Joshua Root) 12 years ago.
fix

Download all attachments as: .zip

Change History (17)

comment:1 Changed 14 years ago by markd@…

Summary: port: dependency passes by inexisting portsBUG: port - dependency passes by inexisting ports

I've noticed that too.

comment:2 Changed 13 years ago by pipping@…

Milestone: MacPorts 1.4

comment:3 Changed 13 years ago by jmpp@…

Milestone: MacPorts 1.4Needs developer review
Owner: changed from darwinports-bugs@… to macports-dev@…
Priority: Nice to haveImportant

Probably MacPorts should bail out claiming the requested port <bogus_port> does not exist and therefore cannot complete installation of port <valid_port_that_listed_bogus_port_in_its_dependency_list>. However, I do not know where the culprit for this behavior could be, therefore setting it to the "needs dev review" milestone.

-jmpp

comment:4 Changed 13 years ago by kballard (Lily Ballard)

Owner: changed from macports-dev@… to eridius@…

comment:5 Changed 13 years ago by kballard (Lily Ballard)

Status: newassigned

comment:6 Changed 13 years ago by kballard (Lily Ballard)

Cc: yves@… added
Resolution: worksforme
Status: assignedclosed

I just tested and I can't replicate this. If I make a port depend on another one that doesn't exist, I get an error.

Marking this as worksforme, please re-open if you can reproduce this issue with latest trunk.

comment:7 Changed 13 years ago by jmpp@…

Milestone: Needs developer reviewMacPorts base bugs

Milestone Needs developer review deleted

comment:8 Changed 13 years ago by nox@…

Cc: yves@… markd@… eridius@… added; yves@… removed
Priority: ImportantHigh
Version: 1.3.2

comment:9 Changed 13 years ago by nox@…

Milestone: MacPorts base bugsMacPorts base enhancements

comment:10 Changed 13 years ago by nox@…

Milestone: MacPorts base enhancementsMacPorts base bugs
Type: enhancementdefect

Sorry, I've modified the wrong field.

comment:11 Changed 12 years ago by ghosthound

Resolution: worksforme
Status: closedreopened

Well well, I just found that this is very reproducible. The current 'perl/p5-mac-apps-launch' port demonstrates this nicely, it contains:

depends_lib-append port:p5-mac-appleevents \

and there is no port named 'p5-mac-appleevents'. I then added to the depends_lib-append list the following line:

port:p5-complete-nonsense-no-way-cant-be

and the port still builds just fine. Neither of the non-existent ports are reported during 'port -v -d build', not even a "DEBUG: Searching for dependency:"... line for either of them.

I tested the non "-append" version of depends_lib in a different port, added an utterly bogus port:BOGUS_NAME_HERE and again, no report of that port being searched for, etc.

Thus I'm certain this bug is present in r33768 (svn up on 20080204), I have not yet tested HEAD (it won't build for me right now).

comment:12 Changed 12 years ago by ghosthound

Cc: ricci@… added

comment:13 Changed 12 years ago by kballard (Lily Ballard)

Interesting twist - it seems that if the missing dependency is listed first, it errors out. If it's listed anywhere after first in the list, it's silently ignored.

comment:14 Changed 12 years ago by jmroot (Joshua Root)

Cc: jmr@… added; yves@… eridius@… removed
Milestone: MacPorts base bugsMacPorts 1.6.1

Nominating for the upcoming release.

Changed 12 years ago by jmroot (Joshua Root)

Attachment: bad_dep.diff added

fix

comment:15 Changed 12 years ago by jmroot (Joshua Root)

Keywords: haspatch added

comment:16 Changed 12 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: reopenedclosed

I went ahead and committed the fix in r36648.

Note: See TracTickets for help on using tickets.