Opened 18 years ago
Closed 17 years ago
#10777 closed enhancement (fixed)
NEW: astyle-1.19
| Reported by: | wyuenho (Jimmy Yuen Ho Wong) | Owned by: | pmq@… |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | ports | Version: | 1.3.2 |
| Keywords: | Cc: | ||
| Port: |
Description
As title, files will be attached later.
Attachments (2)
Change History (7)
Changed 18 years ago by wyuenho (Jimmy Yuen Ho Wong)
Changed 18 years ago by wyuenho (Jimmy Yuen Ho Wong)
| Attachment: | patch-Makefile added |
|---|
comment:2 Changed 18 years ago by pmq@…
| Owner: | changed from yeled@… to pmq@… |
|---|---|
| Summary: | NEW PORT: astyle 1.19 → NEW: astyle-1.19 |
Hi wyuenho,
Thanks for the port. 2 minor things though:
- configure {} should be replaced with use_configure no
- For readability I'd prefer to change the worksrcdir once and for all, because there's no configure phase
Will commit after these. Last question, did you specifically assign the bug to yeled@, or (as I suppose), you assigned to the 'blank' choice? It's important to know because I intend to file an infrastructure bug if trac auto-assigns it to yeled.
Thanks again!
comment:3 Changed 18 years ago by pmq@…
| Status: | new → assigned |
|---|
comment:4 Changed 17 years ago by wyuenho (Jimmy Yuen Ho Wong)
Thanks for the tips, I'm new to writing macports so I don't really know what I'm doing. You can modify the Portfile and commit it to SVN if I made some mistakes. (I wish I had commit permission...)
As the trac bug, I don't quite remember correctly how I filed the bug but I don't think I would have filed the bug to some random people, so it's likely that I did click on the blank choice. But as I said, I don't quite remember.
comment:5 Changed 17 years ago by pmq@…
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed, thanks! I took the liberty to change some whitespace, also I put you as maintainer.
put this in the files directory