Opened 14 years ago

Closed 12 years ago

#10785 closed enhancement (fixed)

Archivemode should look for an existing archive before attempting to build it

Reported by: danielluke (Daniel J. Luke) Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 1.8.0
Component: base Version:
Keywords: Cc: jmpp@…, jmroot (Joshua Root)


As I mentioned on the list, when we changed the target from 'archive' to 'unarchive' we made the time when the port isn't installed on the machine when archivemode is active much longer than it needs to be.

I think the proper behavior would be restored if we change back to 'archive' and modify archive to check for existing archives and not attempt to recreate them if they already exists.

I've got a patch that I haven't done any testing at all to yet (not even to see if the syntax is correct) that I'll attach as my first idea on how to do this.

Attachments (1)

upgrade_fix.patch (1.1 KB) - added by danielluke (Daniel J. Luke) 14 years ago.
Make 'archive' target work correctly for upgrade

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by danielluke (Daniel J. Luke)

Attachment: upgrade_fix.patch added

Make 'archive' target work correctly for upgrade

comment:1 Changed 14 years ago by pipping@…

Milestone: MacPorts 1.4

comment:2 Changed 14 years ago by jmpp@…

Cc: jmpp@… added
Milestone: MacPorts 1.4MacPorts 1.5
Owner: changed from darwinports-bugs@… to macports-dev@…
Priority: Nice to haveExpected
Summary: BUG: upgrade target with archivemode leaves port uninstalled for longer than necessaryArchivemode should look for an existing archive before attempting to build it

Hey Daniel! The upgrade action has been reset to archive from unarchive, so the fix for the primary issue you report will be in MacPorts 1.4. However, I'm leaving this ticket open so we can work on improving the archive target to look for already existing archives and not rebuilding them unnecessarily. Adapting ticket summary accordingly, stting myself on the CC list and the ticket itself to the 1.5 milestone.


comment:3 Changed 14 years ago by yves@…

The same is true of port install, it should look to see if the port is already installed instead of building it and failing at installation.

comment:4 Changed 14 years ago by nox@…

Priority: ExpectedNormal
Version: 1.3.2

comment:5 Changed 13 years ago by jmpp@…

Milestone: MacPorts 1.5MacPorts base enhancements
Type: defectenhancement

comment:6 Changed 12 years ago by jmroot (Joshua Root)

Cc: jmr@… added
Milestone: MacPorts FutureMacPorts 1.8.0
Resolution: fixed
Status: newclosed

Fixed in r50416.

Note: See TracTickets for help on using tickets.