Opened 14 years ago

Closed 14 years ago

#11053 closed defect (fixed)

BUG: jpilot doesn't build with +gtk2 (two problems, patches attached)

Reported by: tristan@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: markd@…
Port:

Description

jpilot with the +gtk2 variant doesn't build, for two reasons. First:

expense.c: In function 'clear_details':
expense.c:681: warning: implicit declaration of function
'gtk_text_backward_delete'
expense.c:681: warning: implicit declaration of function 'GTK_TEXT'
expense.c:682: warning: implicit declaration of function
'gtk_text_get_length'

This is because the Portfile is appending "--enable-gtk2" which is now the default (see http://www.jpilot.org/pipermail/jpilot/2005-December/005616.html)

One solution is to remove the "--enable-gtk2" line from the Portfile. Another alternative might be to make gtk2 the default and gtk1 the variant, since gtk2 is now the default for jpilot. The attached Portfile does this.

The second problem is that jpilot doesn't build because _NL_TIME_FIRST_WEEKDAY is undeclared. This is a known bug and I am attaching the FreeBSD patch for this (see http://www.freebsd.org/cgi/query-pr.cgi?pr=103203).

Attachments (3)

Portfile (937 bytes) - added by tristan@… 14 years ago.
updated jpilot Portfile (gtk2 is default instead of gtk1)
patch-weekday.c (448 bytes) - added by tristan@… 14 years ago.
patch to fix undeclared _NL_TIME_FIRST_WEEKDAY
patch-plugins.c (1.9 KB) - added by tristan@… 14 years ago.
updated plugins patch so that plugins actually work on MacOS

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by tristan@…

Attachment: Portfile added

updated jpilot Portfile (gtk2 is default instead of gtk1)

Changed 14 years ago by tristan@…

Attachment: patch-weekday.c added

patch to fix undeclared _NL_TIME_FIRST_WEEKDAY

comment:1 Changed 14 years ago by tristan@…

Edit: I've found another problem, which is that jpilot doesn't load plugins on MacOS (it is looking for .so files instead of .dylib files). I've attached an updated patch-plugins.c which fixes this. I've also submitted this to the jpilot maintainer, so it may well appear upstream at some point.

Changed 14 years ago by tristan@…

Attachment: patch-plugins.c added

updated plugins patch so that plugins actually work on MacOS

comment:2 Changed 14 years ago by markd@…

Cc: markd@… added

Committed. Thanks!

comment:3 Changed 14 years ago by markd@…

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.