Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#12421 closed enhancement (fixed)

REVISION: subversion 1.4.4_1

Reported by: nox@… Owned by: danielluke (Daniel J. Luke)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: nox@…, danielluke (Daniel J. Luke), ryandesign (Ryan Schmidt)
Port:

Description

Sorry for this large diff, I will cut it in different parts if it bothers the port maintainer, as it does a lot of modifications.

  • First, this revision addresses an unreported bug where subversion could link against apr0 instead of apr1 (see configure.args).
  • Second, I've moved the build of mucc target inside the tools variant, as the mucc tools are not installed without this variant being enabled.
  • Third, I've put the dependency with gettext and libiconv in an NLS variant.
  • Last, I've made some cosmetic changes, like using portfile specific shortcuts to file TCL command, doc files installation in post-destroot{}, sha1 and rmd160 checksums and runtime computation of DYLD_LIBRARY_PATH test env variable.

Attachments (1)

subversion.diff (5.7 KB) - added by nox@… 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by nox@…

Attachment: subversion.diff added

comment:1 Changed 13 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

We should leave NLS and mucc on by default. We should not make variants for those. See discussion on mailing list regarding building the most feature-complete software by default.

In the post-install message you have changed the underscores in "mac_os_x_server_mod_dav_svn" to dashes which you should not have because dashes are not valid in variant names.

No comment on the rest of the changes, other than that it would be better to commit one change at a time.

comment:2 Changed 13 years ago by ryandesign (Ryan Schmidt)

Oh, I see now, you've moved mucc into the tools variant. That might make sense... though I would even prefer that the tools be installed by default and the tools variant deleted. Consider also that I believe mucc will be installed by default as of Subversion 1.5.

comment:3 Changed 13 years ago by danielluke (Daniel J. Luke)

Status: newassigned

The DYLD_LIBRARY_PATH/fs_traverse and bash_completion/file copy changes look like they're good.

I'll try to test them and get them committed soon.

As for the others, I strongly believe that NLS should be enabled by default and don't know of a good reason to not have it included. When adding mucc, we decided that it should also be installed by default (as it will be with subversion 1.5) while the 'tools' variant files don't get installed by a normal make install of subversion (and aren't really necessary) so they make sense as a variant.

comment:4 Changed 13 years ago by nox@…

As nobody agreed with me, I'll now follow the policy of enabling NLS by default, I'm not an integrist after all ;)

For the mucc move, I've done it because I've misunderstood the file delete statement in the tools variant, i believed it only get installed when this variant was enabled, my bad.

comment:5 Changed 13 years ago by danielluke (Daniel J. Luke)

Thoughtful input is always welcome (and your other changes look really good). :)

comment:6 Changed 13 years ago by danielluke (Daniel J. Luke)

Resolution: fixed
Status: assignedclosed

comment:7 Changed 11 years ago by (none)

Milestone: Port Enhancements

Milestone Port Enhancements deleted

Note: See TracTickets for help on using tickets.