Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#12463 closed submission (fixed)

Submission for kdiff3

Reported by: simon@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: simon@…, takanori@…
Port:

Description

Hi,

this is a port for kdiff3. It builds and works fine on PowerPC and Intel.

Simon

Attachments (2)

Portfile (1.4 KB) - added by simon@… 11 years ago.
Portfile.diff (1.9 KB) - added by takanori@… 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by simon@…

Attachment: Portfile added

comment:1 Changed 11 years ago by takanori@…

Cc: simon@… added; simon@… removed

Hi,

I tested your Portfile and found some glitches. Here is a patch to fix them.

  • Add some missing dependencies.
  • Use --with-qt-dir instead of --with-qt-includes/--with-qt-libs. Due to this change, post-configure{} is no longer required.
  • html documents should be installed into ${prefix}/share/doc/kde, not ${prefix}/share/doc/HTML.

If there is no problems, I'll commit it later.

Changed 11 years ago by takanori@…

Attachment: Portfile.diff added

comment:2 Changed 11 years ago by simon@…

Thanks for your help, but I have some problems with your patch.

The first is you don't need to specify all these dependencies, "port:kdelibs3" is enough because it has all these dependencies (except for kdebase3 which I explain later).

And the second is I intentionally didn't add "kdebase3" because kdiff3 builds fine without it (this is also said in their install manual) and so you don't need to install another big package which is unnecessary. I did the same with kcachegrind which is a similar portfile and also works fine.

Thanks for the other changes, they work fine for me.

Simon

comment:3 Changed 11 years ago by simon@…

Cc: simon@… takanori@… added; simon@… removed
Resolution: fixed
Status: newclosed

Committed in [31003].

comment:4 Changed 10 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:5 Changed 10 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.