Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#13055 closed defect (fixed)

rdesktop doesn't build on Mac OS X 10.5 Leopard

Reported by: saispo@… Owned by: cshbell@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: noses@…, jmroot (Joshua Root), gpf@…
Port: rdesktop

Description (last modified by blb@…)

collect2: ld returned 1 exit status
make: *** [rdesktop] Error 1
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_trunk_dports_net_rdesktop/work/rdesktop-1.5.0" && make rdesktop " returned error 2
Command output: /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include  -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.5.0\" -DPACKAGE_STRING=\"rdesktop\ 1.5.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DL_ENDIAN=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1  -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o rdesktop rdesktop.o xwin.o xkeymap.o ewmhints.o xclip.o cliprdr.o  tcp.o iso.o mcs.o secure.o licence.o rdp.o orders.o bitmap.o cache.o rdp5.o channels.o rdpdr.o serial.o printer.o disk.o parallel.o printercache.o mppc.o pstcache.o lspci.o seamless.o -L/opt/local/lib  -L/usr/lib -lcrypto -liconv  -L/usr/X11/lib  -lX11
Undefined symbols:
  "_iconv", referenced from:
      _xclip_send_data_with_convert in xclip.o
      _ui_clip_handle_data in xclip.o
      _rdp_out_unistr in rdp.o
      _rdp_out_unistr in rdp.o
      _rdp_in_unistr in rdp.o
  "_iconv_open", referenced from:
      _xclip_send_data_with_convert in xclip.o
      _xclip_send_data_with_convert in xclip.o
      _xclip_send_data_with_convert in xclip.o
      _ui_clip_handle_data in xclip.o
      _rdp_out_unistr in rdp.o
      _rdp_in_unistr in rdp.o
  "_iconv_close", referenced from:
      _xclip_send_data_with_convert in xclip.o
      _ui_clip_handle_data in xclip.o
      _ui_clip_handle_data in xclip.o
      _rdp_out_unistr in rdp.o
      _rdp_out_unistr in rdp.o
      _rdp_in_unistr in rdp.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make: *** [rdesktop] Error 1

Attachments (2)

rdesktop-libs.diff (611 bytes) - added by jmroot (Joshua Root) 12 years ago.
explicitly tell configure where to find libs
Portfile (1.3 KB) - added by cshbell@… 12 years ago.
New Portfile for rdesktop with diffs to fix #13055

Download all attachments as: .zip

Change History (26)

comment:1 Changed 13 years ago by ryandesign (Ryan Schmidt)

Cc: saispo@… cshbell@… noses@… added
Milestone: Port Bugs
Summary: rdesktop don't build on leopardrdesktop doesn't build on Mac OS X 10.5 Leopard

comment:2 Changed 13 years ago by jmroot (Joshua Root)

Cc: jmr@… added; saispo@… removed

It builds on Leopard for me. Do you somehow not have libiconv installed? If it is installed, what happens if you re-build it?

comment:3 Changed 12 years ago by jmroot (Joshua Root)

Resolution: worksforme
Status: newclosed

No response; closing.

comment:4 Changed 12 years ago by blb@…

Description: modified (diff)
Port: rdesktop added

comment:5 Changed 12 years ago by cshbell@…

I'm seeing some build errors concurrent with this ticket under 1.6.0 (per the new Portfile from http://trac.macports.org/ticket/16633|#16633, which indicates a problem with libiconv, yet MacPorts tracks the latest release (1.12). Will pitch this one to the rdesktop-devel list.

comment:6 Changed 12 years ago by cshbell@…

More specific output from the 1.6.0 build:

Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_net_rdesktop/work/rdesktop-1.6.0" && make rdesktop " returned error 2 Command output: /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.6.0\" -DPACKAGE_STRING=\"rdesktop\ 1.6.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o mppc.o -c mppc.c /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.6.0\" -DPACKAGE_STRING=\"rdesktop\ 1.6.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o pstcache.o -c pstcache.c /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.6.0\" -DPACKAGE_STRING=\"rdesktop\ 1.6.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o lspci.o -c lspci.c /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.6.0\" -DPACKAGE_STRING=\"rdesktop\ 1.6.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o seamless.o -c seamless.c /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.6.0\" -DPACKAGE_STRING=\"rdesktop\ 1.6.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o ssl.o -c ssl.c /usr/bin/gcc-4.0 -O2 -Wall -I/usr/include -I/usr/X11/include -DPACKAGE_NAME=\"rdesktop\" -DPACKAGE_TARNAME=\"rdesktop\" -DPACKAGE_VERSION=\"1.6.0\" -DPACKAGE_STRING=\"rdesktop\ 1.6.0\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DL_ENDIAN=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_LOCALE_H=1 -DHAVE_LANGINFO_H=1 -Dssldir=\"/usr\" -DEGD_SOCKET=\"/var/run/egd-pool\" -DWITH_RDPSND=1 -DHAVE_DIRENT_H=1 -DHAVE_DECL_DIRFD=1 -DHAVE_ICONV_H=1 -DHAVE_ICONV=1 -DICONV_CONST= -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_MOUNT_H=1 -DSTAT_STATVFS=1 -DHAVE_STRUCT_STATVFS_F_NAMEMAX=1 -DKEYMAP_PATH=\"/opt/local/share/rdesktop/keymaps/\" -o rdesktop rdesktop.o xwin.o xkeymap.o ewmhints.o xclip.o cliprdr.o rdpsnd.o rdpsnd_dsp.o tcp.o iso.o mcs.o secure.o licence.o rdp.o orders.o bitmap.o cache.o rdp5.o channels.o rdpdr.o serial.o printer.o disk.o parallel.o printercache.o mppc.o pstcache.o lspci.o seamless.o ssl.o -L/opt/local/lib -L/usr/lib -lcrypto -liconv -L/usr/X11/lib -R/usr/X11/lib -lX11 Undefined symbols:

"_iconv", referenced from:

_xclip_send_data_with_convert in xclip.o _ui_clip_handle_data in xclip.o _rdp_out_unistr in rdp.o _rdp_out_unistr in rdp.o _rdp_in_unistr in rdp.o

"_iconv_open", referenced from:

_xclip_send_data_with_convert in xclip.o _xclip_send_data_with_convert in xclip.o _xclip_send_data_with_convert in xclip.o _ui_clip_handle_data in xclip.o _rdp_out_unistr in rdp.o _rdp_in_unistr in rdp.o

"_iconv_close", referenced from:

_xclip_send_data_with_convert in xclip.o _ui_clip_handle_data in xclip.o _ui_clip_handle_data in xclip.o _rdp_out_unistr in rdp.o _rdp_out_unistr in rdp.o _rdp_in_unistr in rdp.o

ld: symbol(s) not found collect2: ld returned 1 exit status make: * [rdesktop] Error 1

comment:7 Changed 12 years ago by blb@…

A quick check with nm shows that the _open is (at least with 1.12_0) libiconv_open and not iconv_open...

comment:8 Changed 12 years ago by jmroot (Joshua Root)

I didn't see any build problems on Leopard when I tested prior to committing the rdesktop 1.6.0 update. Interesting.

comment:9 Changed 12 years ago by cshbell@…

In testing, removing libiconv as a dependency in the Portfile lets it build fine.

comment:10 in reply to:  9 Changed 12 years ago by jmroot (Joshua Root)

Replying to cshbell@…:

In testing, removing libiconv as a dependency in the Portfile lets it build fine.

Even if libiconv is installed?

comment:11 Changed 12 years ago by cshbell@…

Sorry, should have clarified: No, with libiconv removed/uninstalled.

It's worth pointing out that rdesktop 1.6.0 builds find from source on a vanilla OS X 10.5 install.

comment:12 Changed 12 years ago by jmroot (Joshua Root)

There must be something more going on here, because I had the libiconv port installed when I tested.

comment:13 Changed 12 years ago by blb@…

FYI, /usr/lib/libiconv.2.dylib appears to have both iconv_open and libiconv_open, whereas MacPorts' libiconv only has libiconv_open...either MacPorts' libiconv needs to be updated to define both, or perhaps rdesktop is sometimes detecting the system library for what's available, then linking to MacPorts' actual library.

comment:14 Changed 12 years ago by jmroot (Joshua Root)

Cc: gpf@… added
Resolution: worksforme
Status: closedreopened

Reopening, and adding reporter of duplicate #16719 to cc.

comment:15 Changed 12 years ago by cshbell@…

Any reason we can't simply remove libiconv as a dependency from the Portfile? We should get this resolved.

comment:16 Changed 12 years ago by jmroot (Joshua Root)

Users will often have libiconv installed as a dependency of something else. Just removing the dependency isn't a real fix.

Changed 12 years ago by jmroot (Joshua Root)

Attachment: rdesktop-libs.diff added

explicitly tell configure where to find libs

comment:17 Changed 12 years ago by jmroot (Joshua Root)

Cc: cshbell@… removed
Owner: changed from macports-tickets@… to cshbell@…
Status: reopenednew

Attached patch may help.

comment:18 in reply to:  17 Changed 12 years ago by jefdye@…

Replying to jmr@…:

Attached patch may help.

Is there any resolution on this yet??? I just set up a fresh MacBook Pro today and tried to install the rdesktop and I get the same error as listed in this bug.

Does anyone have an idea of what the fix action is?

comment:19 Changed 12 years ago by jmroot (Joshua Root)

I was never affected by the problem in the first place, so I can't check if the patch works.

comment:20 in reply to:  6 Changed 12 years ago by jefdye@…

I just set up a fresh MacBook Pro today and tried to install the rdesktop and I get the same error as listed in this bug.

This has been open for a year. Any fix on this?

comment:21 Changed 12 years ago by cshbell@…

It hasn't been open for a year on the shipping branch; it has only affected the current port for a few weeks. I am testing the proposed patch in #17 this afternoon.

Changed 12 years ago by cshbell@…

Attachment: Portfile added

New Portfile for rdesktop with diffs to fix #13055

comment:22 Changed 12 years ago by cshbell@…

jmr's patch in {16} fixed the build process for me. I've created a new portfile with the changes and attached it. Recommend it be merged and made active.

comment:23 Changed 12 years ago by blb@…

Resolution: fixed
Status: newclosed

Port updated in r41004, thanks.

comment:24 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.