libiconv 1.12_0 utf8mac patch shouldn't use "system"

[ryandesign (Ryan Carsten Schmidt)]

libiconv 1.12_0 implements the utf8mac patch in a weird way:

post-patch {
        if {![variant_isset disable_utf8mac]} {
                system "cd ${worksrcpath} && patch -p1 < ${filespath}/utf8mac.diff"
        }
}

variant disable_utf8mac {}

Why all this weirdness? The patch shouldn't need to use "system", it shouldn't need -p1. Reimplement this as a plain old ordinary patchfile.

[nox@…]

Why doesn't this patch name have the "patch-" part by the way?

[ryandesign (Ryan Carsten Schmidt)]

Why indeed. :)

This should all be fixed in r31426.

[(none)]

Milestone Port Bugs deleted