Opened 16 years ago

Closed 16 years ago

Last modified 15 years ago

#13922 closed defect (fixed)

ophcrack should not use "exit" command

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc: 0xced (Cédric Luthi)
Port:

Description

ophcrack outputs an error if the install is attempted on a big-endian machine, but it uses "ui_error" followed by "exit" to do this, which does not work anymore because the "exit" command has been removed from MacPorts. "return -code error" should be used instead. I'll attach a patch. Please indicate whether I may commit this fix.

Attachments (1)

Portfile-ophcrack.diff (421 bytes) - added by ryandesign (Ryan Carsten Schmidt) 16 years ago.

Download all attachments as: .zip

Change History (5)

Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: Portfile-ophcrack.diff added

comment:1 Changed 16 years ago by 0xced (Cédric Luthi)

Yes sure, please go ahead.

comment:2 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…

comment:3 Changed 16 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Committed in r33060. Thanks!

comment:4 Changed 15 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.