Opened 12 years ago

Closed 10 years ago

#14142 closed defect (fixed)

Make mysql5 and mysql5-devel as similar as possible

Reported by: ryandesign (Ryan Schmidt) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: jyrkiwahlstedt
Port: mysql5, mysql5-devel

Description

The mysql5 and mysql5-devel portfiles currently differ in a number of ways:

  1. The whitespace differs. Fix this so that it's easy to see at a glance how mysql5 and mysql5-devel differ functionally.
  2. mysql5-devel installs to different directories than mysql5. Fix this so that ports that depend on mysql5 would also work if mysql5-devel were installed instead.
  3. Possibly more?

jwa, the other maintainer of mysql5-devel, agrees with these changes.

Change History (10)

comment:1 Changed 12 years ago by ryandesign (Ryan Schmidt)

  • r33655: whitespace and formatting changes only

comment:2 Changed 12 years ago by ryandesign (Ryan Schmidt)

  • r33697: Changed mysql5-devel to install into the same locations as mysql5. Note that it already installed some files to the same locations before, such that it was never possible to install mysql5 and mysql5-devel at the same time:
$ sudo port install mysql5-devel
Password:
Portfile changed since last build; discarding previous state.
--->  Fetching mysql5-devel
--->  Verifying checksum(s) for mysql5-devel
--->  Extracting mysql5-devel
--->  Configuring mysql5-devel
--->  Building mysql5-devel with target all
--->  Staging mysql5-devel into destroot
Warning: mysql5-devel requests to install files outside the common directory structure!
--->  Installing mysql5-devel 5.1.22-rc_0+darwin_8
--->  Activating mysql5-devel 5.1.22-rc_0+darwin_8
Error: Target org.macports.activate returned: Image error: /opt/local/bin/my_print_defaults5 is being used by the active mysql5 port.  Please deactivate this port first, or use the -f flag to force the activation.
Error: Status 1 encountered during processing.
$

This change will therefore just make it easier for other software to link with either mysql5 or mysql5-devel, whichever one the user may have installed.

comment:3 Changed 12 years ago by ryandesign (Ryan Schmidt)

The mysql5 portfile uses --with-federated-storage-engine (added in #12604) and I thought I needed to add that to mysql5-devel (and did, in r33698). But it turns out MySQL 5.1 enables the federated storage engine not with that switch, but with the --with-plugins switch, and mysql5-devel already has --with-plugins=all (so I reverted my change in r33699).

comment:4 Changed 12 years ago by ryandesign (Ryan Schmidt)

  • r33700: make the master_sites sections more similar by computing and using a variable for the branch version rather than repeating the number in each URL.

comment:5 Changed 12 years ago by ryandesign (Ryan Schmidt)

mysql5-devel uses --without-server; this will be added to the next version of mysql5 via #14146.

comment:6 Changed 11 years ago by ryandesign (Ryan Schmidt)

Port: mysql5 mysql5-devel added
  • r39949: some more whitespace changes to mysql5-devel to match mysql5

comment:7 Changed 11 years ago by ryandesign (Ryan Schmidt)

r44949: remove ${vers} variable from mysql5-devel

comment:8 Changed 11 years ago by ryandesign (Ryan Schmidt)

r44956: remove --without-server configure arg from mysql5-devel

comment:9 Changed 11 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:10 Changed 10 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

The last differences were resolved in r59788.

Note: See TracTickets for help on using tickets.