port upgrade does not work correctly on current pseudo-port

[raimue (Rainer Müller)]

Instead of taking the actual porturl, macports::upgrade searches for the port in the tree which makes the behavior totally unexpected when using the current pseudo-port.

Imagine you got some directory with a Portfile outside of your ports tree which has the same name as a port in the tree. Then run port upgrade in this directory, and not the port from this directory is build and installed, but the one from the tree. This is absolutely not expected behavior.

I think macports::upgrade should take a porturl instead of the name of a port.

[tobypeterson]

Milestone MacPorts base bugs deleted

[mojca (Mojca Miklavec)]

Cc Me!

[neverpanic (Clemens Lang)]

We should probably just remove the possibility to run upgrade with the current port. This is a very uncommon usecase otherwise, so it's probably not worth investing a lot of time into it.

[raimue (Rainer Müller)]

Pull request: ​https://github.com/macports/macports-base/pull/69

[jmroot (Joshua Root)]

Replying to neverpanic:

This is a very uncommon usecase otherwise, so it's probably not worth investing a lot of time into it.

I don't know about that; I do it most of the time when updating ports. It's not needed of course, but it'll be an annoyance to retrain around.

[raimue (Rainer Müller)]

If we want this to work, we are missing an API just like macports::upgrade, but instead of looking up a port by name with mportlookup, it would take a port name of the installed port and a porturl for the replacement. However, that seems a bit complex just for this case.

You can use sudo port install with the current pseudo-port to replace an installed port. The only difference is that port install is allowed to downgrade to an earlier version. Therefore another alternative could be to divert port upgrade current automatically to the install target, maybe with an informational message as the behavior changes slightly.

However, I thought that completely removing this functionality from port upgrade would be a good idea. After a while we could even make port upgrade default to port upgrade outdated to make using MacPorts easier.

[ryandesign (Ryan Carsten Schmidt)]

Replying to raimue:

Imagine you got some directory with a Portfile outside of your ports tree which has the same name as a port in the tree. Then run port upgrade in this directory, and not the port from this directory is build and installed, but the one from the tree. This is absolutely not expected behavior.

I have been bitten by this behavior before, and I agree it was not at all obvious what was happening.

Replying to jmroot:

Replying to neverpanic:

This is a very uncommon usecase otherwise, so it's probably not worth investing a lot of time into it.

I don't know about that; I do it most of the time when updating ports. It's not needed of course, but it'll be an annoyance to retrain around.

I also use sudo port upgrade constantly. Whenever I work on a port, I first cd $(port dir foo) so that I can easily edit Portfile, sudo port install, sudo port upgrade, sudo port uninstall, port info, and so forth, without having to further specify the port name.

Could we only error out if sudo port upgrade is being attempted on a port that is not the one that is in the index?

[jmroot (Joshua Root)]

Ticket retargeted after milestone closed

[jmroot (Joshua Root)]

Ticket retargeted after milestone closed