Opened 12 years ago

Closed 10 years ago

#16470 closed update (fixed)

Port upgrade: python/py25-sphinx 0.1.61950 -> 0.4.2

Reported by: rick@… Owned by: michel.sylvan@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: Cc: ryandesign (Ryan Schmidt), lnielsen@…, haardt@…, arthurk@…
Port: py25-sphinx py26-sphinx

Description

New version requires py25-jinja which is not in macports yet. Filed the port as new at #16469

Attachments (6)

Portfile-py25-sphinx.diff (1.0 KB) - added by rick@… 12 years ago.
Portfile-py25-sphinx-2.diff (1.1 KB) - added by michel.sylvan@… 12 years ago.
Updated py25 patch
Portfile-py-sphinx.diff (1.1 KB) - added by michel.sylvan@… 12 years ago.
Patch for py-sphinx
pysphinx061.diff (1.4 KB) - added by arthurk@… 11 years ago.
py25sphinx061.diff (1.4 KB) - added by arthurk@… 11 years ago.
py25-sphinx 0.6.1
py26sphinx061.diff (1.4 KB) - added by arthurk@… 11 years ago.
py26-sphinx 0.6.1

Download all attachments as: .zip

Change History (27)

Changed 12 years ago by rick@…

Attachment: Portfile-py25-sphinx.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added; michel.sylvan@… removed
Owner: changed from macports-tickets@… to michel.sylvan@…

Assigning to maintainer.

comment:2 Changed 12 years ago by michel.sylvan@…

py25-jinja does not seem to be available yet? Otherwise, the changes match what I have for my Sphinx package for a different project, so it looks good to be committed.

I don't have commit access yet, so once Jinja is in and I can test this I'll ask on the mailing list for the update to be pushed.

comment:3 Changed 12 years ago by ryandesign (Ryan Schmidt)

I did commit py25-jinja 6 hours ago. See #16469. You just need to wait for the PortIndex to be regenerated, which occurs every 12 hours.

comment:4 Changed 12 years ago by ryandesign (Ryan Schmidt)

Cc: lnielsen@… haardt@… added

py-sphinx should of course be updated at the same time.

Has duplicate #15899.

comment:5 Changed 12 years ago by kegan@…

Ticket for py25-jinja #16469 has already been closed more than a week ago. When can we have the new py25-sphinx (0.4.2) ?

Thanks.

comment:6 Changed 12 years ago by michel.sylvan@…

I just e-mailed the PortMgr team with the required patches; apologies for the delay, haven't had time to test the new version previously.

For now, you can apply the patch attached above. Note that it's incomplete: you need to additionally add a depends:run on py25-setuptools

comment:7 Changed 12 years ago by kegan@…

@michel.sylvan No worry. I am not complaining or anything. Just a soft reminder ;)

comment:8 in reply to:  6 Changed 12 years ago by ryandesign (Ryan Schmidt)

Replying to michel.sylvan@…:

I just e-mailed the PortMgr team with the required patches; apologies for the delay, haven't had time to test the new version previously.

There's no need to involve the portmgr group; if you want the patch committed, just say so here and I'll do it.

For now, you can apply the patch attached above. Note that it's incomplete: you need to additionally add a depends:run on py25-setuptools

So I should commit the patch and add "depends_run py25-setuptools"? And I can apply the same patch to py-sphinx? Anything else? If you'd like to attach a revised patch feel free.

Changed 12 years ago by michel.sylvan@…

Attachment: Portfile-py25-sphinx-2.diff added

Updated py25 patch

Changed 12 years ago by michel.sylvan@…

Attachment: Portfile-py-sphinx.diff added

Patch for py-sphinx

comment:9 Changed 12 years ago by michel.sylvan@…

Updated patches filed. Yep; please commit them -- the reason I contacted PortMgr is that I'm asking for commit rights as well, so hopefully soon the update process will get smoother.

comment:10 in reply to:  9 Changed 12 years ago by ryandesign (Ryan Schmidt)

Replying to michel.sylvan@…:

Updated patches filed. Yep; please commit them

You updated py-sphinx to require py-jinja but #16469 only provided a py25-jinja. So we should copy py25-jinja to py-jinja first?

the reason I contacted PortMgr is that I'm asking for commit rights as well, so hopefully soon the update process will get smoother.

Oh good! That will make things easier. :)

comment:11 Changed 12 years ago by ryandesign (Ryan Schmidt)

I applied your patch to py25-sphinx in r40028.

comment:12 Changed 11 years ago by arthurk@…

Resolution: fixed
Status: newclosed

This was fixed 6 months ago.

comment:13 in reply to:  12 Changed 11 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: closedreopened

Replying to arthurk@…:

This was fixed 6 months ago.

Actually it remains unresolved. Nobody responded to my question above ("So we should copy py25-jinja to py-jinja first?") and py-sphinx still depends on the nonexistent py-jinja:

$ port lint py-sphinx
--->  Verifying Portfile for py-sphinx
Error: Unknown dependency: py-jinja
--->  1 errors and 0 warnings found.
$

If you fix that, you can close this ticket.

comment:14 Changed 11 years ago by ryandesign (Ryan Schmidt)

Cc: arthurk@… added

Changed 11 years ago by arthurk@…

Attachment: pysphinx061.diff added

comment:15 Changed 11 years ago by arthurk@…

Sorry. I've attached a patch (pysphinx061.diff) to update py-sphinx to 0.6.1, which also solves the py-jinja problem because sphinx needs Jinja2 since 0.6. I've also renamed the files in /bin to avoid a conflict between the various sphinx versions.

Changed 11 years ago by arthurk@…

Attachment: py25sphinx061.diff added

py25-sphinx 0.6.1

Changed 11 years ago by arthurk@…

Attachment: py26sphinx061.diff added

py26-sphinx 0.6.1

comment:16 Changed 11 years ago by jmroot (Joshua Root)

Type: enhancementupdate

comment:17 Changed 11 years ago by (none)

Milestone: Port Updates

Milestone Port Updates deleted

comment:18 Changed 11 years ago by raimue (Rainer Müller)

Cc: jmr@… added
Port: py26-sphinx added

Adding maintainer of py26-sphinx to CC.

comment:19 Changed 11 years ago by ryandesign (Ryan Schmidt)

This ticket is presumably made obsolete by #20101.

comment:20 Changed 11 years ago by jmroot (Joshua Root)

Cc: jmr@… removed

comment:21 Changed 10 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.