Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#16589 closed defect (fixed)

DEFECT: ffmpeg -version fails to report correct svn revision

Reported by: dbevans (David B. Evans) Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: ffmpeg Cc: acho@…
Port: ffmpeg

Description

Building using the existing Portfile, the command ffmpeg -version yields

FFmpeg version UNKNOWN, Copyright (c) 2000-2008 Fabrice Bellard, et al.

The ffmpeg makefiles depend on the existence of svn metadata to determine the correct svn revision but the current Portfile fetches the distribution using svn export resulting in no metadata.

The attached patch to the Portfile uses svn co in the fetch phase to insure that the correct svn metadata is included. In addition, a pre-fetch phase is included to forcably delete a pre-existing distribution, prior to the fetch phase, if it does not contain metadata. This ensures that an existing installation will correctly upgrade in the presence of a pre-existing svn distribution without metadata.

After building with the modified Portfile, ffmpeg -version yields

FFmpeg version SVN-r14381, Copyright (c) 2000-2008 Fabrice Bellard, et al.

Attachments (1)

patch-ffmpeg-Portfile.diff (1.1 KB) - added by dbevans (David B. Evans) 12 years ago.
Patch for Portfile

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by dbevans (David B. Evans)

Attachment: patch-ffmpeg-Portfile.diff added

Patch for Portfile

comment:1 Changed 12 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to macsforever2000@…
Status: newassigned

comment:2 Changed 12 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: assignedclosed

Committed revision r40473. Thanks and sorry for the delay!

comment:3 Changed 12 years ago by mf2k (Frank Schima)

ryandesign at macports.org had this comment about the patch: "But this just forces the working copy to be discarded and checked out again every time you try to install. I thought the point of having a working copy was so that it could be reused. It would be nice if the working copy were only deleted in the pre-fetch phase if the revision number of the working copy (see the "svnversion" command) doesn't match the revision the port wants to check out."

If you provide an updated patch, I will commit it. Thanks!

comment:4 in reply to:  3 Changed 12 years ago by ryandesign (Ryan Schmidt)

Replying to macsforever2000@…:

ryandesign at macports.org had this comment about the patch: "But this just forces the working copy to be discarded and checked out again every time you try to install. I thought the point of having a working copy was so that it could be reused. It would be nice if the working copy were only deleted in the pre-fetch phase if the revision number of the working copy (see the "svnversion" command) doesn't match the revision the port wants to check out."

If you provide an updated patch, I will commit it. Thanks!

Nevermind, please ignore me. I misread the patch. It's fine as it is. I see now that it only deletes the distpath directory if it is an export, not a working copy.

comment:5 Changed 11 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.