Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#16749 closed defect (fixed)

git-core 1.6.0.2 - incorrect handling of html documentation

Reported by: luc@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.6.0
Keywords: documentation Cc: bryan@…, maccheck@…
Port: git-core

Description

Git expects its html documentation to be in a precise place, represented by the GIT_HTML_PATH environment variable in the source (builtin-help.c), set in the Makefile from the htmldir variable. The default git html path is $(sharedir)/doc/git-doc but the git-core Portfile installs all doc files including the html files in ${prefix}/share/doc/git-core. This makes commands like git help --web COMMAND to fail with the following error message: "fatal: '/opt/local/share/doc/git-doc': not a documentation directory".

The git-core Portfile should either modify the htmldir variable in the Makefile or install the html documenation files in the correct location.

Attachments (2)

Portfile.patch (413 bytes) - added by maccheck@… 12 years ago.
patch-Makefile.diff (713 bytes) - added by maccheck@… 12 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by maccheck@…

Argh, it's hardly to find the difference between git-doc and git-core in the error message of git help... Therefore I didn't understand what the problem was.

I'm attaching patches to fix this issue.

Changed 12 years ago by maccheck@…

Attachment: Portfile.patch added

Changed 12 years ago by maccheck@…

Attachment: patch-Makefile.diff added

comment:2 Changed 12 years ago by blb@…

Resolution: fixed
Status: newclosed

Done in r40902.

comment:3 Changed 12 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.