Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#18019 closed submission (fixed)

lprof 20090119, new port

Reported by: lassi.tuura@… Owned by: nerdling (Jeremy L)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc:
Port: lprof

Description

I have attached a port file for graphics/lprof, an open source tool for icc colour profile management. There's no recent source package so code is taken from the CVS repository, the version is simply the date I took the code.

Attachments (4)

Portfile (2.3 KB) - added by lassi.tuura@… 11 years ago.
Portfile.2 (2.5 KB) - added by nerdling (Jeremy L) 11 years ago.
styling/whitespace updates
Portfile.3 (2.5 KB) - added by nerdling (Jeremy L) 11 years ago.
/Applications/MacPorts -> $applications_dir
Portfile.4 (2.7 KB) - added by nerdling (Jeremy L) 11 years ago.
added changes to configure.args

Download all attachments as: .zip

Change History (27)

Changed 11 years ago by lassi.tuura@…

Attachment: Portfile added

comment:1 Changed 11 years ago by nerdling (Jeremy L)

Owner: changed from macports-tickets@… to snc@…
Status: newassigned
Version: 1.6.01.7.0

comment:2 Changed 11 years ago by nerdling (Jeremy L)

I tried building lprof and received a problem with qmake being not found. It is, I believe, called qmake-mac on my box (from a fresh cmake install).

CMake Error at /opt/local/share/cmake-2.6/Modules/FindQt4.cmake:1664 (MESSAGE):

Qt qmake not found!

Call Stack (most recent call first):

CMakeLists.txt:78 (FIND_PACKAGE)

Changed 11 years ago by nerdling (Jeremy L)

Attachment: Portfile.2 added

styling/whitespace updates

Changed 11 years ago by nerdling (Jeremy L)

Attachment: Portfile.3 added

/Applications/MacPorts -> $applications_dir

comment:3 Changed 11 years ago by nerdling (Jeremy L)

Can you check out line 36 of the Portfile? I believe there's a backslash where there ought not be one, but you know your configure flags better than me :-)

comment:4 in reply to:  3 ; Changed 11 years ago by lassi.tuura@…

Can you check out line 36 of the Portfile? I believe there's a backslash where there ought not be one, but you know your configure flags better than me :-)

Thanks for reviewing the port file and your changes.

Which backslash(es) are you referring to? For CMAKE_SYSTEM_PREFIX_PATH I believe it actually means to have the quotes and the semicolon in the variable value. But no, I don't know these configure flags any better than you I am afraid :-/ I know next to nothing about cmake, I effectively just copied flags from existing portfiles using both cmake and qt until it built.

If you want I can bisect through the options to reduce them to the minimal set.

Was the issue with cmake not finding qmake solved?

comment:5 in reply to:  2 Changed 11 years ago by lassi.tuura@…

Replying to snc@…:

I tried building lprof and received a problem with qmake being not found. It is, I believe, called qmake-mac on my box (from a fresh cmake install).

CMake Error at /opt/local/share/cmake-2.6/Modules/FindQt4.cmake:1664 (MESSAGE):

Qt qmake not found!

Call Stack (most recent call first):

CMakeLists.txt:78 (FIND_PACKAGE)

For the record here, as I replied in e-mail but the message never made it to the tracking system:

Thanks for the review! I have:

$ port provides =qmake /opt/local/bin/qmake is provided by: qt4-mac

$ port contents qt4-mac | grep /bin/qmake

/opt/local/bin/qmake /opt/local/libexec/qt4-mac/bin/qmake

LPROF built for me straight from that portfile on two different 10.4.11 systems. Neither system had any version of qt pre-installed anywhere on the system. Any ideas why this doesn't work for you?

comment:6 Changed 11 years ago by nerdling (Jeremy L)

Your qt4-mac provides qmake, but mine provides qmake-mac. Can you please supply me with the output of port installed qt4-mac?

comment:7 in reply to:  4 ; Changed 11 years ago by nerdling (Jeremy L)

Replying to lassi.tuura@…:

Which backslash(es) are you referring to? For CMAKE_SYSTEM_PREFIX_PATH I believe it actually means to have the quotes and the semicolon in the variable value. But no, I don't know these configure flags any better than you I am afraid :-/ I know next to nothing about cmake, I effectively just copied flags from existing portfiles using both cmake and qt until it built.

Well, I looked through them again and I don't see what I saw before!

comment:8 in reply to:  7 Changed 11 years ago by nerdling (Jeremy L)

Replying to lassi.tuura@…:

Which backslash(es) are you referring to? For CMAKE_SYSTEM_PREFIX_PATH I believe it actually means to have the quotes and the semicolon in the variable value. But no, I don't know these configure flags any better than you I am afraid :-/ I know next to nothing about cmake, I effectively just copied flags from existing portfiles using both cmake and qt until it built.

I take that back. Line 36 has the quotes escaped but the rest of the commands do not. This seems suspicious to me. Once I've figured out why my qmake is named differently, this will be next on my list to check, however you said it built just fine for you. It could just be a non-issue.

comment:9 Changed 11 years ago by lassi.tuura@…

$ port installed qt4-mac The following ports are currently installed:

qt4-mac @4.4.3_0+dbus+docs+mysql5+sqlite+ssl (active)

Hm, earlier I said it installed from a system without qt. I think I did actually try that first, and it installed fine, but then later decided I wanted qt with more options and did "sudo port install qt4-mac +ssl +sqlite +mysql5". I don't think the above variants affect qmake, but I could of course be wrong.

comment:10 Changed 11 years ago by lassi.tuura@…

Concerning CMAKE_SYSTEM_PREFIX_PATH, you can try "grep -r CMAKE_SYSTEM_PREFIX_PATH /opt/local/var/macports/sources". For me it returns 17 matches all of the same form. I really don't know more than that, but if you think there's a real problem, I can try to dig further into it. Just let me know.

comment:11 in reply to:  9 Changed 11 years ago by nerdling (Jeremy L)

Replying to lassi.tuura@…:

$ port installed qt4-mac The following ports are currently installed:

qt4-mac @4.4.3_0+dbus+docs+mysql5+sqlite+ssl (active)

Hm, earlier I said it installed from a system without qt. I think I did actually try that first, and it installed fine, but then later decided I wanted qt with more options and did "sudo port install qt4-mac +ssl +sqlite +mysql5". I don't think the above variants affect qmake, but I could of course be wrong.

The qt4-mac on my system is using a newer portfile than yours — 4.4.3_1. The newer does not have the variants that you're using. It only has noframework, webkit, and universal. Could you do a sudo port selfupdate && port upgrade -u outdated, and then reinstall lprof?

Of further note, the portfile says it depends on the qt4-mac libraries, so it would have to be built prior to allowing the installing of lprof. If it actually doesn't depend on qt4-mac we should remove it from the dependencies.

comment:12 Changed 11 years ago by lassi.tuura@…

LProf is a Qt application, so I assume qt4-mac is required. Or did I misunderstand your comment about the dependency?

Regarding self-update/upgrade -- no thanks, not right now :-) I did attempt a global upgrade about month and a half ago, and ended up in extended nightmare which eventually reduced to rm -fr /opt/local and reinstalling absolutely everything. As the system runs several macports servers I depend on for daily work, I am highly reluctant to attempt this difficult an upgrade much more than about once a year. (One feature of the previous upgrade was that it attempted to rebuild commonly used libraries, such as libintl, for _every single port that needed them._ Basically the reinstallation grew exponentially in time as it progressed up the tree. But to be honest I am not sure if it made any progress at all, it just seemed to run compilations in a near-infinite loop. Plus (re)building packages such as tetex or qt is just painful.)

comment:13 Changed 11 years ago by nerdling (Jeremy L)

I'm sorry you went through most of that trouble with MacPorts 1.6. Those have almost entirely been addressed with MacPorts 1.7.

Rather than using sudo port upgrade -u outdated, would it be safe to just sudo port deactivate qt4-mac and sudo port -f install qt4-mac a new version of it (you can then activate/deactivate the different versions to fall back)? Please do a sudo port selfupdate beforehand.

comment:14 Changed 11 years ago by lassi.tuura@…

OK, I'll try that tonight, thanks.

comment:15 Changed 11 years ago by lassi.tuura@…

I braved for the macports upgrade to 1.7 plus "sudo port upgrade -u outdated" on another system. Other than running through the night and leaving broken doxygen and tetex, it appears it actually worked fine.

Yes I confirm there are a couple of problems finding qmake-mac and lrelease-mac programs. I guess qt4-mac package changes the names of the executables to avoid conflicts with x11-based qt. At any rate adding -DQT_QMAKE_EXECUTABLE=${prefix}/bin/qmake-mac -DQTTRANS_LRELEASE_EXECUTABLE=${prefix}/bin/lrelease-mac to configure.args fixes it.

At that point the build dies in link with SSL symbol errors. I didn't have time to investigate further, but it seems something may have changed about qt/openssl integration. I am fairly sure the application itself makes no use whatsoever of SSL, and probably could not care less about those symbols...

comment:16 Changed 11 years ago by nerdling (Jeremy L)

I can create OS-dependent configure.args (through variant darwin X). That should address the QT problems.

As for SSL linking, I'll see what I can find at this end once I get these flags fixed.

comment:17 Changed 11 years ago by lassi.tuura@…

Hi, I don't think there's any need to make the flags OS-dependent. I doubt the application will work on OS X with X11-flavour of Qt. At any rate, even if it was technically possible, it would probably be counter-productive since the application is designed to be colour managed, and I think there's better chance for the "native" APIs to accomplish that than going via X11.

comment:18 Changed 11 years ago by nerdling (Jeremy L)

An interesting development: It now configures with your changes and is presently building. The Qt/SSL problems must have been fixed.

Changed 11 years ago by nerdling (Jeremy L)

Attachment: Portfile.4 added

added changes to configure.args

comment:19 Changed 11 years ago by nerdling (Jeremy L)

Let me know if the 4th Portfile works and I'll commit it!

comment:20 Changed 11 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: assignedclosed

Timeout: Committed in r47902.

comment:21 Changed 11 years ago by nerdling (Jeremy L)

Sorry, meant r47905.

comment:22 Changed 10 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:23 Changed 10 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.