Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#18021 closed submission (fixed)

logwatch 7.3.6, new port

Reported by: lassi.tuura@… Owned by: nerdling (Jeremy L)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc:
Port: logwatch

Description

I have attached a port file for security/logwatch, a log file analysis tool.

Attachments (9)

Portfile (2.1 KB) - added by lassi.tuura@… 10 years ago.
launchd.plist (747 bytes) - added by lassi.tuura@… 10 years ago.
Portfile.2 (3.3 KB) - added by lassi.tuura@… 10 years ago.
org.macports.logwatch.plist (702 bytes) - added by nerdling (Jeremy L) 10 years ago.
since i had suggested looking at pspp, i was informed that these should be included in ./files
Portfile.3 (2.5 KB) - added by nerdling (Jeremy L) 10 years ago.
updated for the included launchd file
Portfile.4 (3.0 KB) - added by nerdling (Jeremy L) 10 years ago.
added ui_msg to inform user of launchd startup script
patch-logwatch.diff (1.7 KB) - added by nerdling (Jeremy L) 10 years ago.
ui_msg changes, destroot.keepdirs added, bumped revision. builds and runs successfully for me.
Portfile.5 (3.0 KB) - added by lassi.tuura@… 10 years ago.
Combined merge of previous diff plus requested changes from macports admins.
patch-logwatch2.diff (2.8 KB) - added by lassi.tuura@… 10 years ago.
Cumulative patch.

Download all attachments as: .zip

Change History (27)

Changed 10 years ago by lassi.tuura@…

Attachment: Portfile added

Changed 10 years ago by lassi.tuura@…

Attachment: launchd.plist added

comment:1 Changed 10 years ago by nerdling (Jeremy L)

Lassi: You might consider letting macports create the launchd item as the install path is not necessarily /opt/local.

comment:2 Changed 10 years ago by nerdling (Jeremy L)

Cc: snc@… added

Cc Me!

comment:3 Changed 10 years ago by lassi.tuura@…

Thanks. By "letting macports create" do you mean there's some standard mechanism to spit out launchd items, or I should just sed the install path in the Portfile to match $prefix? If the former, could you please point me to the documentation or an example, as I think I have missed it...

comment:4 Changed 10 years ago by nerdling (Jeremy L)

Yes, there's an actual mechanism built-in that you can base your efforts from. Check out http://guide.macports.org/#reference.startupitems

comment:5 Changed 10 years ago by lassi.tuura@…

Thanks! I had looked at that documentation, but wasn't able to work out how to create a cron-style job instead of a daemon, and was hesitant to whack at port-generated start-up item so much. Can you suggest a concrete example I could look at? If there's no direct support for cron-style, which do you feel is more obvious and maintainable, using the existing infrastructure to produce basic plist then edit it with plutil / defaults, or the current template adjusted to account for $prefix etc.?

comment:6 Changed 10 years ago by nerdling (Jeremy L)

It seems cron-style launchd items are not yet implemented in MacPorts. Looking at #16969, it might be on the way in the future.

That being said, I'd suggest that you have the launchd item created in your portfile dynamically (or do a find/replace from macports on the one supplied to fill in the paths). Making sure the path are correct is fairly important part of macport's functionality.

For ideas on how to write the files, I previously generated other kinds of scripts found at the bottom of: http://trac.macports.org/changeset/45332/trunk/dports/math/pspp/Portfile

Let me know if you need some more ideas.

comment:7 Changed 10 years ago by lassi.tuura@…

OK, I'll remodel the port file so it writes the launchd item rather than taking a stock file.

Changed 10 years ago by lassi.tuura@…

Attachment: Portfile.2 added

comment:8 Changed 10 years ago by lassi.tuura@…

I updated port file to generate launchd plist dynamically rather than taking a static file.

Changed 10 years ago by nerdling (Jeremy L)

Attachment: org.macports.logwatch.plist added

since i had suggested looking at pspp, i was informed that these should be included in ./files

Changed 10 years ago by nerdling (Jeremy L)

Attachment: Portfile.3 added

updated for the included launchd file

Changed 10 years ago by nerdling (Jeremy L)

Attachment: Portfile.4 added

added ui_msg to inform user of launchd startup script

comment:9 Changed 10 years ago by nerdling (Jeremy L)

Cc: snc@… removed
Owner: changed from macports-tickets@… to snc@…
Status: newassigned
Version: 1.6.01.7.0

The latest portfile and included script builds and installs for me.

If everything is the way you'd like it I'm ready to commit these.

comment:10 Changed 10 years ago by lassi.tuura@…

Thanks, yes, am happy with it as it is. I've been running it for months now, and did test before submitting the update that it did produce the desired result. (Well, I fudged the time it runs, waited for the time to pass, inspected the report it mailed, then restored the time back to night time.)

comment:11 Changed 10 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: assignedclosed

Committed as r46644.

comment:12 Changed 10 years ago by lassi.tuura@…

Sorry, I hadn't noticed some of the changes to the port file you had added -- when you said the "latest" I hadn't noticed the changes made by you, as I didn't receive any e-mail notification and didn't read the web page carefully enough. My apologies.

The "ui_msg" lines refer to "dnsmasq", should this not be "logwatch"? There is also a missing "h" in "launcd". Both are on line 58. (Thanks for adding the message, I was wondering how to make one and under which circumstances.)

I also noticed the plist now runs the command directly rather than via /bin/sh. I am not sure this will work as for me logwatch needed /opt/local/bin in $PATH. Does logwatch run for you via launchd without setting $PATH? I wonder if I have some anti-dependency on my system.

comment:13 in reply to:  12 Changed 10 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: closedreopened

Replying to lassi.tuura@…:

The "ui_msg" lines refer to "dnsmasq", should this not be "logwatch"? There is also a missing "h" in "launcd". Both are on line 58. (Thanks for adding the message, I was wondering how to make one and under which circumstances.)

You're absolutely correct. I was mimicking dnsmasq's ui_msg too closely!

I also noticed the plist now runs the command directly rather than via /bin/sh. I am not sure this will work as for me logwatch needed /opt/local/bin in $PATH. Does logwatch run for you via launchd without setting $PATH? I wonder if I have some anti-dependency on my system.

I've never had an issue with running the binaries directly from launchd. You'll notice that the binary is run with it's full path to avoid the issue you likely had. Launchd confirms the event is loaded (sudo launchctl list | less logwatch) and will sit waiting for the designated time to occur.

I did notice that, upon running the binary directly (sudo logwatch) there was an error: /opt/local/var/cache/logwatch No such file or directory at /opt/local/bin/logwatch line 751. It seems we need to create that directory.

I'll attach a couple patches shortly showing how I intend to fix these issues. If they're satisfactory I'll apply them.

Changed 10 years ago by nerdling (Jeremy L)

Attachment: patch-logwatch.diff added

ui_msg changes, destroot.keepdirs added, bumped revision. builds and runs successfully for me.

comment:14 Changed 10 years ago by lassi.tuura@…

I think some confusion on my part here, sorry. The script creates ${destroot}${prefix}/var/cache/${name} and even the undesirable ".turd" file. Did the directory really not exist for you after installing logwatch?

I previously had some problem not with running logwatch itself, but something it wanted to execute internally. I am unable to replicate it right now; it appears to work fine without setting $PATH, and I do not recall the problem I originally had. Let's leave it as it is, without $PATH.

I will upload shortly my updated port file, trying to account for your changes plus the other requests: move reinplace to build, don't create .turd file, and don't touch /Library in destroot step. I also attached a diff, but it's not against svn, it's just against your Portfile.4.

Changed 10 years ago by lassi.tuura@…

Attachment: Portfile.5 added

Combined merge of previous diff plus requested changes from macports admins.

comment:15 in reply to:  14 Changed 10 years ago by nerdling (Jeremy L)

Replying to lassi.tuura@…:

I think some confusion on my part here, sorry. The script creates ${destroot}${prefix}/var/cache/${name} and even the undesirable ".turd" file. Did the directory really not exist for you after installing logwatch?

The portfile does create the ${destroot}${prefix}/var/cache/{$name} but it doesn't install it. The destroot.keepdirs parameter forces it to install that directory. That was the only error I had come across running logwatch.

Changed 10 years ago by lassi.tuura@…

Attachment: patch-logwatch2.diff added

Cumulative patch.

comment:16 Changed 10 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: reopenedclosed

Committed as r46695. If there are new issues, I suggest a new ticket: All original issues have been addressed.

comment:17 Changed 10 years ago by jmroot (Joshua Root)

Type: enhancementsubmission

comment:18 Changed 10 years ago by (none)

Milestone: Port Submissions

Milestone Port Submissions deleted

Note: See TracTickets for help on using tickets.