Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#18455 closed defect (fixed)

clean up of wikkawiki

Reported by: nerdling (Jeremy L) Owned by: nerdling (Jeremy L)
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc: brian@…
Port: wikkawiki

Description

There are some things that need updated in wikkawiki.

  1. The php5 and mysql5 dependencies need rewritten to check for binaries (there exists more than one package that produces a working php5/mysql5.
  2. Does wikkawiki really require a MySQL server to be present on the same computer? Is it not sufficient to access a MySQL server on another computer? If so, no dependency on a MySQL port should be stated.
  3. The destroot phase should be reworked so that the symlink in the osxdocpath is created inside the destroot.
  4. if [variant] content should just be put into the variants

Do you approve of the attached patch? Are there other changes you would like made?

Attachments (5)

patch-wikkawiki.diff (2.1 KB) - added by nerdling (Jeremy L) 10 years ago.
patch-wikkawiki.2.diff (4.2 KB) - added by nerdling (Jeremy L) 10 years ago.
further changes (whitespace, post-activate, lone {)
patch-wikkawiki.3.diff (3.9 KB) - added by nerdling (Jeremy L) 10 years ago.
xinstall => file attributes, modified ${wikkapath}
patch-wikkawiki.4.diff (2.4 KB) - added by nerdling (Jeremy L) 10 years ago.
moved ui_msg back into post-activate. seemingly cannot override per variant.
patch-wikkawiki.5.diff (3.5 KB) - added by brian@… 10 years ago.
Correct target dir in post-destroot symlink creation

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by nerdling (Jeremy L)

Attachment: patch-wikkawiki.diff added

Changed 10 years ago by nerdling (Jeremy L)

Attachment: patch-wikkawiki.2.diff added

further changes (whitespace, post-activate, lone {)

comment:1 Changed 10 years ago by ryandesign (Ryan Schmidt)

Looks good, except "xinstall -m 0666 {$wikkapath}/wikka.config.php" won't work; xinstall copies a file from one place to another, but if you only want to change its mode, then "file attributes" is the way to go. Also you may want to change the wikkapath variable so it does not begin with the destroot (instead prepend the destroot variable to the wikkapath variable when you want to use it) so that you can use the wikkapath variable in the use_osx_docroot post-destroot phase too.

Changed 10 years ago by nerdling (Jeremy L)

Attachment: patch-wikkawiki.3.diff added

xinstall => file attributes, modified ${wikkapath}

comment:2 in reply to:  1 Changed 10 years ago by nerdling (Jeremy L)

Status: newassigned

Replying to ryandesign@…:

…you can use the wikkapath variable in the use_osx_docroot post-destroot phase too.

Does the OS X apache allow following symlinks? If not, then the use_osx_docroot won't work.

Changed 10 years ago by nerdling (Jeremy L)

Attachment: patch-wikkawiki.4.diff added

moved ui_msg back into post-activate. seemingly cannot override per variant.

Changed 10 years ago by brian@…

Attachment: patch-wikkawiki.5.diff added

Correct target dir in post-destroot symlink creation

comment:3 Changed 10 years ago by brian@…

Suggested changes have been tested and look fine to me.

Does wikkawiki really require a MySQL server to be present on the same computer? Is it not sufficient to access a MySQL server on another computer? If so, no dependency on a MySQL port should be stated.

We've never really tested the app against a remote MySQL instance. In our experience, the vast majority of our users would probably expect MySQL to be installed locally.

comment:4 Changed 10 years ago by nerdling (Jeremy L)

Resolution: fixed
Status: assignedclosed

Committed as r46832.

comment:5 Changed 10 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

Note: See TracTickets for help on using tickets.