Opened 11 years ago

Closed 9 years ago

#18603 closed defect (fixed)

mp3fs: cannot install if prefix is not /opt/local and other issues

Reported by: ryandesign (Ryan Schmidt) Owned by: mail@…
Priority: Normal Milestone:
Component: ports Version: 1.7.0
Keywords: Cc: nerdling (Jeremy L)
Port: mp3fs

Description

There were some issues with the mp3fs port as it was submitted in #18381, first mentioned on macports-dev by Rainer and by myself:

  1. The lines "distname mp3fs-${version}" and "livecheck.distname mp3fs" should be removed because those are the default values.
  2. pkgconfig should be marked as a build dependency, not a library dependency.
  3. Patchfiles should not reside on your personal web space; they should instead be copied to the port's files directory.
  4. The string "/opt/local" should usually not occur in a portfile, because MacPorts might be installed in a different prefix. Use the variable "${prefix}" instead.

1, 2, and 3 were fixed by Jeremy in r46512. 4 was partially fixed in that revision but one occurrence of /opt/local remained, so the port still doesn't work if the prefix is not /opt/local.

Some additional points that occur to me now:

  1. Your configure arguments should not be appended to "configure.post_args" but instead should be written to "configure.args" and there is no need to enclose them in quotes.
  2. There is no need to use "master_sites sourceforge:mp3fs"; if the SourceForge project name is the same as the port name you can just say "master_sites sourceforge"
  3. You should not put ${distfiles} into the checksums. It is unnecessary if ${distfiles} contains only a single file, as it does in this case, and it is a syntax error if it contains multiple files.

I'll attach a patch to fix these remaining issues. If you agree, I'll be happy to commit it.

Attachments (1)

mp3fs.diff (1.0 KB) - added by ryandesign (Ryan Schmidt) 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by ryandesign (Ryan Schmidt)

Attachment: mp3fs.diff added

comment:1 in reply to:  description Changed 11 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

  1. Your configure arguments should not be appended to "configure.post_args" but instead should be written to "configure.args" and there is no need to enclose them in quotes.

Actually, make that: these are environment variables, not arguments to the configure script, so they should go in configure.env, not configure.args. I'll update the patch.

comment:2 Changed 11 years ago by (none)

Milestone: Port Bugs

Milestone Port Bugs deleted

comment:3 Changed 9 years ago by jmroot (Joshua Root)

I'm pretty sure maintainer timeout has occurred and you can just commit this... ;-)

comment:4 Changed 9 years ago by drkp (Dan Ports)

Resolution: fixed
Status: newclosed

All either fixed or mooted in r75023

Note: See TracTickets for help on using tickets.